Supporting Multiple RenderKits about javaserverfaces-spec HOT 23 CLOSED

Reported by @edburns

from javaserverfaces-spec.

@edburns said:
This is the java.net issue tracker version of JSFA162 from Scarab.

from javaserverfaces-spec.

@edburns said:
enact

from javaserverfaces-spec.

rogerk said:
Sent proposal to EG.

from javaserverfaces-spec.

rogerk said:
Changes:

SECTION: Modified Files

M jsf-api/src/javax/faces/render/ResponseStateManager.java
---- added static RENDER_KIT_ID_PARAM String to be used as the
---- name of the hidden field for the renderKitId.
M jsf-ri/conf/share/jsf_core.tld
---- added renderKitId attribute for tag "view"
M jsf-ri/src/com/sun/faces/application/ViewHandlerImpl.java
---- in calculateRenderKitId(), check for the existence of the
---- renderKitId as a request parameter (was written as hidden field)
---- if present, return that as the renderKitId. Otherwise, return
---- the defaultRenderKitId (if present), otherwise, return HTML_BASIC.
---- Make sure we use the ResponseStateManager.writeState implementation
---- to write out the renderKitId hidden field.
---- ResponseStateManagerImpl.writeState does it for both. However, the
---- calls to that method only happen for client side state saving.
---- Hence the additional call to ResponseStateManager.writeState for server
---- side state saving.
M jsf-ri/src/com/sun/faces/renderkit/ResponseStateManagerImpl.java
---- only write out the state of the view for client side state saving;
---- However, write out the renderKitId hidden field regardless of state
---- saving mode.
M jsf-ri/src/com/sun/faces/taglib/jsf_core/ViewTag.java
---- added renderKitId attribute.
---- if there is no renderKitId attribute specified, set the UIViewRoot
---- renderKitId property to be the defaultRenderKitId (if present) or,
---- HTML_BASIC (if not present).
M jsf-ri/systest/build-tests.xml
M jsf-ri/systest/src/com/sun/faces/systest/model/TestBean.java
M jsf-ri/systest/src/com/sun/faces/systest/render/TextRenderer.java
M jsf-ri/systest/web/WEB-INF/faces-config.xml

A jsf-ri/systest/src/com/sun/faces/systest/RenderKitsTestCase.java
A jsf-ri/systest/src/com/sun/faces/systest/render/ButtonRenderer.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomRenderKitImpl.java
A
jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseStateManagerImpl.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseWriter.java
A jsf-ri/systest/src/com/sun/faces/systest/render/FormRenderer.java
A jsf-ri/systest/web/renderkit04.jsp
A jsf-ri/systest/web/renderkit05.jsp

---- this test consists of two jsp pages. renderkit04.jsp has no
---- renderKitId specified in <f:view>; renderKit05.jsp has a
---- <f:view renderKitId="CUSTOM">; Each page has a submit button on it
---- to transer control to the other page.
---- As each page is displayed, the renderKitId and responseWriter are
---- displayed as present at the time in UIViewRoot and FacesContext.
---- Also note that renderkit05.jsp utilizes a CUSTOM renderkit/responseWriter/
---- responseStateManager/and components.

from javaserverfaces-spec.

rogerk said:
Created an attachment (id=25)
Change bundle for this issue.

from javaserverfaces-spec.

rogerk said:
Change bundle forth coming.

SECTION: Modified Files

M jsf-ri/conf/share/jsf_core.tld
---- Added renderKitId attribute for "view"
M jsf-ri/src/com/sun/faces/application/ViewHandlerImpl.java
---- calculateRenderKitId - attempt to get renderKitId from request
M jsf-ri/src/com/sun/faces/renderkit/ResponseStateManagerImpl.java
---- write out renderKitId as hidden field
---- (if there is a default specified, and the render kit identifier
---- is not the default).
M jsf-ri/src/com/sun/faces/taglib/jsf_core/ViewTag.java
---- add renderKitId
---- setProperties: set renderKitId (if not null) on UIViewRoot
---- if renderKitId is null, and renderKitId not
---- already set on UIViewRoot, use
---- defaultRenderKitId. As a last resort, use
---- HTML_BASIC.
M jsf-ri/systest/build-tests.xml
---- add new test
M jsf-ri/systest/src/com/sun/faces/systest/model/TestBean.java
M jsf-ri/systest/src/com/sun/faces/systest/render/TextRenderer.java
M jsf-ri/systest/web/renderkit03A.jsp
M jsf-ri/systest/web/WEB-INF/faces-config.xml
M jsf-ri/systest/web/golden/renderkit03A.txt
---- for new test

A jsf-ri/systest/src/com/sun/faces/systest/RenderKitsTestCase.java
A jsf-ri/systest/src/com/sun/faces/systest/render/ButtonRenderer.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomRenderKitImpl.java
A
jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseStateManagerImpl.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseWriter.java
A jsf-ri/systest/src/com/sun/faces/systest/render/FormRenderer.java
A jsf-ri/systest/web/renderkit04.jsp
A jsf-ri/systest/web/renderkit05.jsp
---- for new test

from javaserverfaces-spec.

rogerk said:
Created an attachment (id=28)
Issue 50 change bundle

from javaserverfaces-spec.

rogerk said:
Another change bundle forthcoming.

from javaserverfaces-spec.

rogerk said:
SECTION: Modified Files

M jsf-ri/conf/share/jsf_core.tld
---- added renderKitId attribute for "view"
M jsf-ri/src/com/sun/faces/application/ViewHandlerImpl.java
---- calculateRenderKitId - attempt to get renderKitId from request
M jsf-ri/src/com/sun/faces/renderkit/ResponseStateManagerImpl.java
---- write out renderKitId as hidden field
---- (if there is a default specified, and the render kit identifier
---- is not the default).
M jsf-ri/src/com/sun/faces/taglib/jsf_core/ViewTag.java
---- add renderKitId
---- setProperties: set renderKitId (if not null) on UIViewRoot
---- if renderKitId is null, and renderKitId not
---- already set on UIViewRoot, use
---- defaultRenderKitId. As a last resort, use
---- HTML_BASIC.
M jsf-ri/systest/build-tests.xml
---- add new test
M jsf-ri/systest/src/com/sun/faces/systest/model/TestBean.java
M jsf-ri/systest/src/com/sun/faces/systest/render/TextRenderer.java
M jsf-ri/systest/web/renderkit03A.jsp
M jsf-ri/systest/web/WEB-INF/faces-config.xml
M jsf-ri/systest/web/golden/renderkit03A.txt

---- for new test

A jsf-ri/systest/src/com/sun/faces/systest/RenderKitsTestCase.java
A jsf-ri/systest/src/com/sun/faces/systest/render/ButtonRenderer.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomRenderKitImpl.java
A
jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseStateManagerImpl.java
A jsf-ri/systest/src/com/sun/faces/systest/render/CustomResponseWriter.java
A jsf-ri/systest/src/com/sun/faces/systest/render/FormRenderer.java
A jsf-ri/systest/web/renderkit-default-clear.jsp
A jsf-ri/systest/web/renderkit-default.jsp
A jsf-ri/systest/web/renderkit04.jsp
A jsf-ri/systest/web/renderkit05.jsp
A jsf-ri/systest/web/renderkit06.jsp
---- for new test

from javaserverfaces-spec.

rogerk said:
Created an attachment (id=29)
Change bundle for this issue.

from javaserverfaces-spec.

@edburns said:
M jsf-ri/src/com/sun/faces/renderkit/ResponseStateManagerImpl.java

Don't write HTML manually. Use responseWriter.startElement(),
addAttribute(), etc. Make sure to end the element.

Other than that, looks great. Make that change and
you have r=edburns.

from javaserverfaces-spec.

@edburns said:
fixed.

from javaserverfaces-spec.

@edburns said:
Prepare to delete "spec" subcomponent.

from javaserverfaces-spec.

@edburns said:
Move all to 1.2

from javaserverfaces-spec.

@manfredriem said:
Closing resolved issue out

from javaserverfaces-spec.

File: issue-50.zip
Attached By: rogerk

from javaserverfaces-spec.

File: issue-50.zip
Attached By: rogerk

from javaserverfaces-spec.

File: issue-50.zip
Attached By: rogerk

from javaserverfaces-spec.

Issue-Links:
depends on
JAVASERVERFACES_SPEC_PUBLIC-480
JAVASERVERFACES_SPEC_PUBLIC-482

from javaserverfaces-spec.

Was assigned to rogerk

from javaserverfaces-spec.

This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-50

from javaserverfaces-spec.

Marked as fixed on Thursday, March 4th 2010, 6:09:23 am

from javaserverfaces-spec.