Merged theme branches and examples about fries HOT 9 CLOSED

Added PR #91

from fries.

Let's put this on development branch first. I'll set develop as the default branch so we can merge these without affecting the latest stable release. Also, I'll be creating a branch for version 2.1 with a list of features. I'm planning to add both holo dark and light themes to that as well.

from fries.

Closing this for now.

from fries.

Let's put this on development branch first.

Yeah, that's what I did in my fork too. Sorry, that's my fault. Didn't wanted tor create the PR to be merged into master but rather into a new branch.

I'll set develop as the default branch

👍

so we can merge these without affecting the latest stable release.

Well, that's actually what tags are for, isn't it? Even though current master can be considered stable (and shouldn't be default for adding new commits (except for urgent fixes) anyway), I thought the lastest stable is 2.0.3? ;-)

(BTW, I noticed that you link to the https://github.com/jaunesarmiento/fries/archive/master.zip in the readme file rather than to https://github.com/jaunesarmiento/fries/archive/2.0.3.zip (=latest stable). Is that on purpose?)

Also, I'll be creating a branch for version 2.1 with a list of features. I'm planning to add both holo dark and light themes to that as well.

👍

from fries.

@jaunesarmiento Would you merge my changes from PR #91 into the new develop branch? If so, I can send you a new PR now. In case you don't, note it contains some JS fixes too. You may still want to merge these changes, even though you don't want to merge themes atm.

from fries.

Well, that's actually what tags are for, isn't it? Even though current master can be considered stable (and shouldn't be default for adding new commits (except for urgent fixes) anyway), I thought the lastest stable is 2.0.3? ;-)

Oh, right. Haha. Good to have someone who points out my mistakes. :)

(BTW, I noticed that you link to the https://github.com/jaunesarmiento/fries/archive/master.zip in the readme file rather than to https://github.com/jaunesarmiento/fries/archive/2.0.3.zip (=latest stable). Is that on purpose?)

Yes, I noticed that. It's my fault. It's supposed to be pointed to 2.0.3. :P

from fries.

Would you merge my changes from PR #91 into the new develop branch? If so, I can send you a new PR now. In case you don't, note it contains some JS fixes too. You may still want to merge these changes, even though you don't want to merge themes atm.

Send a PR to wip/v2.1.0. I'll merge it right away.

from fries.

here you go: #93

from fries.

closing this one

from fries.