Code Monkey home page Code Monkey logo

Comments (2)

sgravrock avatar sgravrock commented on June 11, 2024

toBeDefined is an unfortunate relic of the very early (pre-1.3) days, when there was no .not and the only way to negate a matcher was to write a second one that did the opposite. All the other negated matchers were removed in 2.0, with only the toBeDefined/toBeUndefined pair retained. I think that if there was no toBeDefined and you'd had to write .not.toBeUndefined() instead, you probably wouldn't have been surprised by its behavior.

I think the proposed matcher is relatively niche. Normally I'd reach for a more specific assertion like toEqual(someExpectedValue), toEqual(jasmine.any(String)), or even toBeTruthy(). But I can see how it would be useful in some cases, and there's precedent in jasmine.anything(), so I don't mind having it as long as it's not going to confuse people.

The toBeAnything name is consistent with jasmine.anything, but I think it's vague enough to cause the same kind of problem that you ran into with toBeDefined. What about something like toBeNullOrUndefined? So in the normal case where you want to assert that you got some sort of non-nothing value back, you'd write expect(something).not.toBeNullOrUndefined(). A bit more verbose, but I think the explicitness is good in this case.

from jasmine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.