Comments (9)
Also, --replace foo,bar
with no new
parameter works on bar,foo
but reports it as two records.
(Same goes for --replace foo,bar ""
)
from buku.
We need to support 2 things:
- replace a tag with multiple tags (comma separated)
- remove a tag
I think we can add a new option to remove a tag explicitly instead of linking it to replace tag.
from buku.
It might be a good idea, I guess (though I don't really care that much either way); this is regarding what happens if the first argument given to --replace
contains commas.
I believe it should be either explicitly supported (and handled correctly), or explicitly disallowed (with attempts to do so being rejected).
from buku.
We should explicitly ignore as it is ambiguous.
Also, you need to care about both the cli and api use cases as a collaborator and contributor. This is exactly the reason I am so defensive about maintaining status quo.
from buku.
ignore - disallow.
from buku.
This is exactly the reason I am so defensive about maintaining status quo.
If I didn't care about CLI and API, I wouldn't be asking to fix them when they're dysfunctional.
What I said is that having or not having tag removal as a separate CLI option (as opposed to "replace with nothing") makes little difference to me, and it's not what this thread is about anyway. If you want to separate them, though, I'd suggest disallowing empty input for replacement (there wouldn't be much point to it otherwise).
ignore
"Ignoring" would mean "do nothing and pretend there was no action requested in the first place" 😅. To "explicitly disallow" would involve telling a CLI user that he can't replace multiple tags with one, and an API call should signal a failure (which means either a failed result or an exception, depending on the general protocol… I guess in case of replace_tag()
that would mean returning False
on such input).
from buku.
Yes, "explicitly disallow" is what I also prefer.
from buku.
Incidentally, printing out the failure reason to stdout is not a good API behaviour (i.e. there's no sane way of capturing it to communicate in a network response or in GUI). The correct way would be to either return it or to pass it in a raised exception instead.
from buku.
Yes, now we have to take that approach. When it was written, it was written with the CLI in mind.
from buku.
Related Issues (20)
- How to list 20 or 30 or more favorites instead of listing 10 HOT 1
- Autoimport from firefox with several installed editions HOT 1
- after upgrade from 4.7 to 4.8 bukuserver can't add a new bookmark - internal server error HOT 4
- Characters not handled in the bookmark title HOT 2
- Why not "buku a" to add a bookmark? HOT 5
- add flag --immutable HOT 2
- XMPP: buku as a chat software (aka app) HOT 14
- Multiple URLs per bookmark / Alternative URLs for bookmarks HOT 5
- Does Buku support adding images to bookmarks? HOT 5
- Feature Request: Documentation on how to use buku in docker-compose with multi-device-setup. HOT 1
- Add: Disable autotagging HOT 2
- regression test failure with 4.9 release HOT 2
- Tags yielded by auto-tagging have a white space
- CLI argument to skip auto-tagging/comment/title HOT 2
- SQLite table for tags HOT 2
- "--offline" doesn't work HOT 1
- [Support] Questions about CLI arguments HOT 3
- Add search option to include and exclude columns HOT 3
- [Discussion] Split bukuserver from buku
- [Support] BukuBot issue with database lock error HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buku.