"Error: failed to deserialize user out of session" unwanted on production about passport HOT 14 CLOSED

Fixed!

You can now invalidate an existing login session by setting user to false or null when calling done inside deserializeUser.

passport.deserializeUser(function(obj, done) {
  done(null, false);  // invalidates the existing login session.
});

Most ORMs set the result to null if the record wasn't found, as is the case with Mongoose. So, this will work as expected if you are deleting user records while they have an active session. In that case, findById sets user to null, which is passed through to Passport and the session will be invalidated.

passport.deserializeUser(function(id, done) {
  User.findById(id, function (err, user) {
    done(err, user);
  });
});

This is fixed in [email protected], which has just been published to the npm registry.

from passport.

I would note in the documentation that you have to return null or false. I tried returning undefined instead of null and came here through Google.

from passport.

A world where null and false are the same but are not the same as undefined makes no sense. The following are true facts of Javascript:

null == false == undefined
null !== false !== undefined

Inventing your own truth table where null == false != undefined makes things unnecessarily confusing.

from passport.

Just a heads up for folks stumbling across this—it turns out TypeORM returns undefined and not null. You should do something like (await User.findOne({where: {id: obj.id}})) || false for Passport to work properly.

from passport.

Agreed. I'm leaning towards option 1 as the proper fix.

from passport.

strong +1 for one.

from passport.

+10086 for this issue...

from passport.

At least allowing the developer to handle the error would be key. +1 for at least exposing that.

from passport.

+1 on this. Is there a workaround for the issue right now?

from passport.

Hello guys, any idea when this will be fixed?

from passport.

I'm having this exact same issue on version 0.1.12 with passport-facebook.

from passport.

Thank you! This should definitely find it's way into the documentation.

from passport.

This working for me, put the next following commands in your terminal:
redis-cli
select 1
FLUSHALL

from passport.

created PR to fix undefined problem #975

from passport.