Code Monkey home page Code Monkey logo

Comments (4)

jaredhanson avatar jaredhanson commented on September 3, 2024 2

A failWithError option has been implemented. It can be used to address this issue as follows:

app.post('/login',
  passport.authenticate('local', { successRedirect: '/home', failWithError: true }),
  function(err, req, res, next) {
    // handle error
    return res.render('login-form');
  }
);

For further details, see this comment on issue #126.

from passport-local.

thatmarvin avatar thatmarvin commented on September 3, 2024

I was wondering the same thing. The first example in http://passportjs.org/guide/authenticate.html mentions that Passport returns a 401 Unauthorized, but I don't see a way to do something like rendering a login form. A callback might be useful here?

In the next example, it looks like POSTing to /login with invalid credentials yields a HTTP 302 back to /login. In HTTP speak, the response is saying "/login is temporarily available in /login", which doesn't make sense. Practically speaking, the original POST data (username, password etc) is now lost since the page you now see is a new GET request to /login.

A 401 Unauthorized is the appropriate response in this case ("what you sent to /login is invalid"), but that means that the interface failureRedirect would no longer make sense. Again, maybe a failure callback instead?

from passport-local.

525c1e21-bd67-4735-ac99-b4b0e5262290 avatar 525c1e21-bd67-4735-ac99-b4b0e5262290 commented on September 3, 2024

bump

from passport-local.

jaredhanson avatar jaredhanson commented on September 3, 2024

Linking to passport #3, which has relevant discussion on this topic.

from passport-local.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.