Comments (4)
jaredhanson
commented on June 30, 2024
Agreed. Do you have time to add a test case for empty usernames and remove that check? If so I'll get a pull request merged in soon. Otherwise I'll make the modifications, but I can't promise a timeframe.
from passport-http.
davidpodolsky
commented on June 30, 2024
Jared,
Any chance you could my pull request merged in? Bug is fixed, tested, and I wrote the proper test cases to test for empty username. Builds are passing. Thanks for your time.
from passport-http.
davidpodolsky
commented on June 30, 2024
Closed by mistake. I will close after the pull.
from passport-http.
jaredhanson
commented on June 30, 2024
Merged both, with modifications and additional tests. Everything should check out, so I published to npm as passport-http v0.2.2. Let me know if any other changes are needed. Thanks!
from passport-http.
Related Issues (20)
- Passwords containing ':' are not read properly HOT 5
- When express app is mounted at non-root endpoint, passport-http returns 400 HOT 4
- Basic auth does not accept Authentication header. HOT 1
- User not logged-out when trying to log-in with incorrect password (BasicStrategy)
- Custom error code HOT 4
- passReqToCallback support missing from Digest strategy
- Document digest nonce validation callback HOT 2
- Two different basic strategies HOT 1
- New location for examples (multi)
- Strategy naming for basic auth HOT 1
- HTTP digest on router
- Session not saved after login using passport-http
- How to login from HTML form? HOT 1
- Digest: How to validate nonces without user? HOT 2
- Digest: return algorithm in response header
- BasicStrategy not found HOT 2
- [Documentation] Should mention passport.initialize() HOT 1
- PLEASE NOMINATE MAINTAINERS HOT 2
- Digest still not working in nested routes in Express 4 HOT 1
- Future of this project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport-http.