Switch to Docker Hub automated builds about janusgraph-docker HOT 4 CLOSED

I'm not sure if we can use Docker Hub automated builds with our current file/directory setup.

Docker Hub appears to support the following modes: having a single Dockerfile, and build a new version with each new tag, or just the branch (you can use regexes to specify branch names or tags). However, Docker Hub does not appear to support regexes for source paths, which is what we would want to do; docker/hub-feedback#759 is a feature request for this type of a feature.

To use automated builds, we would need to use a single Dockerfile, and have a per-version branch or tag, which makes it hard to keep Dockerfile build steps or README files consistent across versions,
since you have to port them to each tag/branch — this is also pointed out in the feature request above.

We can certainly have automated builds via Travis CI on every commit, with appropriate tags (including manual maintenance of where latest points to), but it doesn't appear to be possible to do what we want purely via Docker Hub, with no extra steps, at least not at this time.

from janusgraph-docker.

I was going to suggest this myself, and then realized you've already proposed this as well, so 👍!

Would this also require keeping a separate Dockerfile for every released version, right? Right now, we're keeping only the latest x.y image which is hard-coded to a particular x.y.z image, so once we've defined 0.3.2, for example, the repo at master no longer has the Dockerfile definition of 0.3.0 or 0.3.1, so it's unclear how it was built, without going back in history to see what the Dockerfile looked like at the time the build was made.

from janusgraph-docker.

Would this also require keeping a separate Dockerfile for every released version, right?

I think this is independent of the question whether we build and push the images ourselves from Travis CI or use Docker Hub automated builds. For both, we need a Dockerfile of everything we want to push.

I actually don't have a strong opinion on whether we should include Dockerfiles for all versions we ever pushed or only a Dockerfile for the newest version of every branch. One downside I see with the approach to have Dockerfiles even for old versions like 0.2.0 is that pushing updates for such old versions is probably unexpected for users months or even years after the release of that version of JanusGraph.

But any way, I think that we should treat those two aspects as two unrelated issues as we can switch to Docker Hub automated builds without changing our current approach to only keep the latest x.y Dockerfile and we can switch to including all x.y.z Dockerfiles irrespective of whether we are pushing the images from Travis CI or with automated builds via Docker Hub.

from janusgraph-docker.

Looks like this won't be supported by Docker Hub any time soon as the issue was closed for inactivity. So, I'm also closing this for now. We can still re-open it later if this becomes possible and we still want to change the workflow of how be build and deploy our images.

from janusgraph-docker.