Comments (3)
Hey @benpatterson,
Is that a big issue? I think >= node 8 is the most recent stable version. Not sure from where puppeteer dependency comes from, perhaps it's a "dependency of a dependency"?
from sleek.
@janczizikow The EOL for node 6 is April 2019. (Node 4 EOL's this month.) It's your call if you want to take action...I just wanted to call this out since I ended up spending time troubleshooting an install failure; took some digging to determine why the failure was occurring when following the install steps. Could also be a doc update if you'd rather keep package.json
where it is.
puppeteer
is a dependency of penthouse
. I'm happy to put in a PR if that would help, but it's all good if you want to handle this a different way. Thanks for taking the time to read through my issue.
from sleek.
Hey @benpatterson,
I just took a look: penthouse
is a dependency of critical. It's a package to inline the critical CSS, which helps to improve page render time. Did you fix this issue on your machine by upgrading node or removing penthouse
? I don't really want to give up on critical
. Since this theme focuses on performance, having an autorunner task to inline the critical chunks of CSS it's rather a priority. I think the easiest solution would be to update the docs like you said.
Thanks to you for your time and creating this issue π
from sleek.
Related Issues (20)
- The hero img looks strange on high resolution display HOT 4
- throw error: Unhandled 'error' event while using gulp img
- Is it necessary to install Ruby environment?
- Migrate to Gulp 4 HOT 4
- Accessibility errors found in your template
- Using the gem, how can I run `gulp img`? HOT 1
- Help getting script to run HOT 1
- Sleek not supported HOT 1
- How can I display an image generated with gulp depending on the client's device? HOT 4
- Multilingual support HOT 1
- The Captcha refuses to work.
- How do I change the code snippet theme
- can you help me? HOT 1
- Jekyll 4.0.0 compatibles issue
- I should click twice 'header__toggle' If I changed browser size. HOT 1
- Images do not show up properly when using custom domain
- gulp img doesnβt work on macOS Catalina 10.15.3
- .
- SVG help
- node-gyp rebuild Err because [email protected] are suspend . Can you help maintain and update the latest dependencies of the project ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sleek.