areas appears selected in UI after rebind even though its selected state !== true about imagemapster HOT 1 CLOSED

The docs indicate that rebind will ...change areas that are already selected to be rendered with the new options.

Prior to commit 3de37f3 (line 723) this was true. However, in this commit, the behavior changed to not persist previously selected state and instead, completely rebuild Area Data items.

This change does appear intentional as the test case related to rebind also changed (Line 336). The test case itself incorporates singleSelect but there was no code modified/added to condition on singleSelect value so its difficult to know for certain if previous selected state should have been retained and just respected singleSelect somehow or if this test is just confirming that even when there are more than one areas configured with singleSelect === true they are selected after rebind.

Given the code changes in rebind method to call buildDataset and the fact that there is clearly no attempt to try to preserve state, the only logical conclusion was that the behavior was intentionally changed despite the fact that there was no major version update.

The net result of this commit is that rebind & unbind/init are nearly identical with the only exception being the "prep" work of creating the wrapper, etc. This difference is actually the issue identified in #379.

Trying to find a reliable and deterministic approach to maintaining selected state while still respecting the options passed gets complicated and could lead to different behavior in certain situations. For example:

1. How should singleSelect be treated if true. If there are areas in config marked as selected, the any previous areas selected should be deselected and only the configured areas remain. If there are no areas configured as selected but more than one areas has a state of selected, which one remains selected?
2. If an area is configured as staticState (or it was configured but now isn't) how to adjust state accordingly

Based on all of this, shifting this issue from treating it as selected state should still be selected to the area should no longer be drawn since its no longer selected after a rebind. In short, previous selected state is ignored and everything is based on current configuration passed. As mentioned, this minimizes the value of rebind but does stay consistent with the changes made in 3de37f3 by simply closing the gap/bug where the UI doesn't match internal selected state.

One additional note regarding behavior rebind - As written, it expects that the AREAS have not been modified in any way expect for the mapKey and href. It will ignore any other changes to the underlying HTML and in some cases (e.g. manual manipulation of coords) will cause unexpected results. This also means the order of the areas in the HTML should not change, no new areas should be added and no areas should be removed. If any of these changes are required, unbinding and re-initializing (e.g. $img.mapster('unbind').mapster({ ... })) is required.

from imagemapster.