Fix overlaps on input about midi_degradation_toolkit HOT 4 CLOSED

Example 3: Both
Input:

....o--------
......o----..

Output:

....o-o------

from midi_degradation_toolkit.

Essentially, we want any ms which has a sustain to still have a sustain, and any ms which has an onset to still have an onset.

from midi_degradation_toolkit.

Test case, which covers most (all?) of the probable sticking points:

df = pd.DataFrame({
    'onset': [50, 75, 150, 200, 200, 300, 300, 300],
    'track': [0, 0, 0, 0, 0, 0, 0, 1],
    'pitch': [10, 10, 20, 10, 20, 30, 30, 10],
    'dur': [300, 25, 100, 125, 50, 50, 100, 100]
})
res = pd.DataFrame({
    'onset': [50, 75, 150, 200, 200, 300, 300],
    'track': [0, 0, 0, 0, 0, 0, 1],
    'pitch': [10, 10, 20, 10, 20, 30, 10],
    'dur': [25, 125, 50, 150, 50, 100, 100]
})
assert fix_overlaps(df).equals(res)

from midi_degradation_toolkit.

In particular, the current version of fix_overlaps in data_structures looks like it would fail if the overlapping notes are non-consecutive (since it has eliminated the groupby('pitch')). The groupby might unfortunately be necessary...

from midi_degradation_toolkit.