implicit arguments are skipped, resulting in compilation error about f90wrap HOT 6 CLOSED

There's currently no support for implicit arguments in f90wrap, as I never came across a Fortran code which used these, but as usual I'm open to issues/pull requests :-)

from f90wrap.

Your code is huge, so it is hard to tell but I guess that 2 small modifications might do it :
1 - in file "f90wrapgen.py", function "visit_Procedure", line 332 : comment "self.write("implicit none")"
2 - in file "parse.py", function "check_subt", probably in the block starting at line 726, after the comment "Select only first declaration that matches entries in argument list" : find a way to keep the undeclared arguments.
3 - Repeat 2 for the function "check_funct"
Optional : give the type "implicit" to undeclared arguments for the doc_string.

It is of course the step 2 that is the most involved and I have not enough understanding of your code today to propose an precise way to do this.

from f90wrap.

Hi James :)
I have tinkered a bit with your code to add basic inference of implicit types for arguments and function returns. Would you like me to provide the modified code, in the event of a future integration ? (I also "upgraded" some "removing this or that" lines from logging to warning, as I feel that missing functionalities should really be noted)

from f90wrap.

Please do, that would be great! If you create a pull request here on GitHub I will review your changes and incorporate as soon as possible.

On 3 May 2016, at 18:27, MrYann [email protected] wrote:

Hi James :)
I have tinkered a bit with your code to add basic inference of implicit types for arguments and function returns. Would you like me to provide the modified code, in the event of a future integration ? (I also "upgraded" some "removing this or that" lines from logging to warning, as I feel that missing functionalities should really be noted)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

from f90wrap.

Ok, I tried, but must have done something wrong : it says +2487 -0 lines, and I have only added < 20 lines.

Yann

Le 3 mai 2016 à 19:32, James Kermode [email protected] a écrit :

Please do, that would be great! If you create a pull request here on GitHub I will review your changes and incorporate as soon as possible.

On 3 May 2016, at 18:27, MrYann [email protected] wrote:

Hi James :)
I have tinkered a bit with your code to add basic inference of implicit types for arguments and function returns. Would you like me to provide the modified code, in the event of a future integration ? (I also "upgraded" some "removing this or that" lines from logging to warning, as I feel that missing functionalities should really be noted)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #44 (comment)

from f90wrap.

Got it … uploaded in wring folder. Sorry for the inconvenience.

Yann

Le 3 mai 2016 à 19:47, Yann Grisel [email protected] a écrit :

Ok, I tried, but must have done something wrong : it says +2487 -0 lines, and I have only added < 20 lines.

---

Yann

Le 3 mai 2016 à 19:32, James Kermode <[email protected] mailto:[email protected]> a écrit :

Please do, that would be great! If you create a pull request here on GitHub I will review your changes and incorporate as soon as possible.

On 3 May 2016, at 18:27, MrYann <[email protected] mailto:[email protected]> wrote:

Hi James :)
I have tinkered a bit with your code to add basic inference of implicit types for arguments and function returns. Would you like me to provide the modified code, in the event of a future integration ? (I also "upgraded" some "removing this or that" lines from logging to warning, as I feel that missing functionalities should really be noted)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #44 (comment)

from f90wrap.