Comments (6)
I obtained a working solution by having f90wrap's fortran code generator completely ignore the renaming of types with reserved keywords (supposedly handled by f2py) and using .orig_name everywhere; what worked is when I got f90wrap's pywrapgen to implement the renaming of classes. However, I had to manually change source code for pywrapgen.py in the beginning of write_dt_wrappers
to be
def write_dt_wrappers(self, node, el, properties):
import numpy
name_map = numpy.f2py.crackfortran.badnames
if ft.strip_type(el.type) in name_map:
cls_name = name_map[ft.strip_type(el.type)]
Then normalize the class name after filtering out reserved keywords
cls_name = normalise_class_name(cls_name, self.class_names)
from f90wrap.
That looks like an OK solution. Does f90wrap still pass all the regression tests? (make test
in examples/
) If so we could make that change in master
. If you would be willing to make a PR which does this, and also adds a new test that would have shown the problem that would be great!
from f90wrap.
Sure, I can make the PR after running the tests. Fingers crossed...
from f90wrap.
Edit: nvm, found that I had to change python
to python3
in the Makefile
@jameskermode it seems that some of the tests fail on master: the arrayderivedtype test failed on the master branch (i.e., without any of my changes) with the following error
Traceback (most recent call last):
File "tests.py", line 23, in <module>
import arrayderivedtype
File "/Users/ananthsridharan/codes/f90wrap/examples/arrayderivedtypes/arrayderivedtype.py", line 2, in <module>
import _arrayderivedtype
ImportError: No module named _arrayderivedtype
make[1]: *** [test] Error 1
make: *** [test] Error 2
from f90wrap.
so all the default tests passed with my changes (good). Added a new test on my fork and making it more complex.
Still working out nesting derived types with reserved names and catching/replacing all reserved words in all possible instances. Will post a PR when I'm happy with it
from f90wrap.
@jameskermode I've submitted a PR with another test. There are edge cases like when a user creates an array of a derived type called size
that start introducing ambiguity in the fortran compiler; this is a fortran error and I'm not accounting for those instances.
from f90wrap.
Related Issues (20)
- Python 3.11 support HOT 8
- Pre-build f90wrap wheels for windows HOT 3
- Derived types containing allocatable character arrays
- `integer, value, intent(in)`/`integer, value` arguments converted to/wrapped as `real`
- Wrong module class name in a call to `f90wrap.runtime.FortranDerivedTypeArray` HOT 2
- numpy > 1.23 support HOT 2
- Switch to pyproject.toml based build system HOT 7
- duplicate symbol in formal argument list HOT 2
- Issues on Mac OS X - for f90wrap 0.2.12 HOT 1
- BUG: Routines including procedure arguments (callbacks) are excluded HOT 1
- Can `f90wrap`parse FORD docstrings?
- unexpected removal of procedures associated with derived types HOT 1
- install fails on macos 14 HOT 4
- Binary Wheels for Mac HOT 1
- example with fortran to python callback function fails with as of f90wrap v0.2.13: "bad argument to internal function" HOT 1
- Parser fails on asterisk in subroutine argument list HOT 2
- Fix Windows wheels HOT 1
- Suggestions on wrapping a code HOT 4
- Handle collision in array wrapper (that breaks CI intermittently)
- Question: Why is `FortranModule` a `Singleton`? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from f90wrap.