Code Monkey home page Code Monkey logo

Comments (3)

jakubfiala avatar jakubfiala commented on July 26, 2024

@raphinesse thanks for the suggestion! I agree completely that such a signature would work better. It is an API-breaking change, so I'm going to flag this for v0.3.0.

Please do submit PRs if you can.

from atrament.

jakubfiala avatar jakubfiala commented on July 26, 2024

stupid me, I meant to say v1.0.0

from atrament.

raphinesse avatar raphinesse commented on July 26, 2024

It doesn't have to be breaking. You could still support the old API and deprecate it. Something along the lines of:

function atrament(canvas, options) {
  if (typeof options === 'number') {
    console.warn('Calling style deprecated. Use new style instead. [Further information]')
    // convert old style arguments to options object
  }
  // Use new options object
}

To be more concise: overload the function ☺️

from atrament.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.