Code Monkey home page Code Monkey logo

Comments (3)

jakobkmar avatar jakobkmar commented on August 18, 2024

Hey, I know this looks like a bug at first, but I decided go with this behaviour on purpose.
The reason is that detecting duplicates in a reliable way is not really possible. Additionally, when detected correctly, handling these duplicates is also very hard, since there are lots of different situations where one repo would be preferred over the other and vice versa. Also, the preferred repo might change at any time.
In the end, it was just the easiest to download the file multiple times and let the loader handle duplicated mods. This is actually no problem since e.g. Fabric does not crash with duplicated mods, and instead always takes the best version (which often is the most recent version) and loads that one.

I hope that this understandable - if you have any concerns, please let me know!

Moreover, pacmc doesn't allow to uninstall this additional mod afterwards, as it's a required dependency.

Yes, a pacmc exclude command is planned.

from pacmc.

endrjux avatar endrjux commented on August 18, 2024

Ah, ok. If it doesn't crash then it's fine. (TBH I didn't even try, I assumed it'll crash :-D) That's reasonable and I too think it would be hard to correctly asses which mods are duplicates.

from pacmc.

rvveber avatar rvveber commented on August 18, 2024

You could compare checksums of existing files with checksums of to be installed files to find out if they are duplicates?

from pacmc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.