Comments (3)
Hey, I know this looks like a bug at first, but I decided go with this behaviour on purpose.
The reason is that detecting duplicates in a reliable way is not really possible. Additionally, when detected correctly, handling these duplicates is also very hard, since there are lots of different situations where one repo would be preferred over the other and vice versa. Also, the preferred repo might change at any time.
In the end, it was just the easiest to download the file multiple times and let the loader handle duplicated mods. This is actually no problem since e.g. Fabric does not crash with duplicated mods, and instead always takes the best version (which often is the most recent version) and loads that one.
I hope that this understandable - if you have any concerns, please let me know!
Moreover, pacmc doesn't allow to uninstall this additional mod afterwards, as it's a required dependency.
Yes, a pacmc exclude
command is planned.
from pacmc.
Ah, ok. If it doesn't crash then it's fine. (TBH I didn't even try, I assumed it'll crash :-D) That's reasonable and I too think it would be hard to correctly asses which mods are duplicates.
from pacmc.
You could compare checksums of existing files with checksums of to be installed files to find out if they are duplicates?
from pacmc.
Related Issues (20)
- [Feature Request] Prompt users whether to install optional dependencies HOT 4
- pacmc list command not working as expected when not using default archive HOT 1
- [Feature Request] Provide ability to filter searched mods by the version of archive
- Error when installing HOT 3
- Add a search limit option
- Make Curseforge slug resolving more reliable HOT 1
- Issues when removing the default archive
- kotlinx.serialization.json.internal.JsonDecodingException: Unexpected JSON token at offset 392: Expected string literal but 'null' literal was found. HOT 1
- Embedded dependencies are not supported in the latest release HOT 1
- The loader Quilt is not supported by Curseforge HOT 1
- Exception when calling "pacmc search better" HOT 6
- Cannot search "Item Scroller` by masady from CurseForge HOT 2
- CurseForge returned a null `downloadUrl` causing an exception HOT 1
- Incorrect dependcies for Sodium Extra from Modrinth HOT 2
- Empty transaction for no compatible version
- DependencyType does not contain element with name 'embedded' HOT 1
- Detect whether archive is in mods folder or not
- this directory chooser code work with debug build when i am making msi package then its not work open only swing dialog
- dead? HOT 1
- Archives with relative paths fail on windows
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pacmc.