Code Monkey home page Code Monkey logo

Comments (3)

jakezatecky avatar jakezatecky commented on May 17, 2024

Yes, this is because the checked property only records the node values. If a node value is duplicated by any other node, then you will experience this behavior. The tree therefore requires that each node have a unique value. You can solve this be merely concatenating the parent nodes to the child nodes (e.g. A-B and E-B).

I suppose we could validate all supplied nodes for value uniqueness and throw an error if a duplicate is detected, providing more developer-friendly debugging. Might impact performance, so it probably makes sense to have this as a property that can be disabled (e.g. validateUniqueness).

A more exotic option could also exist, where the node value are automatically concatenated with their parent values, but that would change the resulting tree's values.

from react-checkbox-tree.

purak24 avatar purak24 commented on May 17, 2024

I don't think validating nodes for value uniqueness will be a good idea. I can think of many use cases where leaf nodes may have same values but under different categories.

What I ended up doing is pushing the key ({index}-{node.name}) instead of name in the checked array. That works!

from react-checkbox-tree.

jakezatecky avatar jakezatecky commented on May 17, 2024

Closing since this is pretty easy for the developer to adjust to.

from react-checkbox-tree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.