Code Monkey home page Code Monkey logo

Comments (10)

rfgamaral avatar rfgamaral commented on June 16, 2024

Today I have also noticed that most of the selected page title poor quality comes from the fact that the text is being drawn twice, one on top of the other. I couldn't fix that issue per se but I changed the code enough to see how it would look like if the title were to be drawn only once and looked much better (but not as good as a TextView render).

from viewpagerindicator.

protyposis avatar protyposis commented on June 16, 2024

Here's a simple fix for the issue: #48

from viewpagerindicator.

rfgamaral avatar rfgamaral commented on June 16, 2024

Just to make it clear, that fix does not exactly fix the issue here described. It's only for the "double title drawing", not for the general poor text rendering quality.

from viewpagerindicator.

protyposis avatar protyposis commented on June 16, 2024

It's not the perfect solution but like you already said, still much better than before... I thought it would be a good temporary solution until the control has been rewritten to use TextViews.

from viewpagerindicator.

rfgamaral avatar rfgamaral commented on June 16, 2024

Yes, but that's just for the selected title, the other ones don't have this "double drawing" problem.

But this is just a feature request to rewrite the control with TextViews, @JakeWharton hasn't pitched in yet so we don't know what he feels about such rewrite...

from viewpagerindicator.

JakeWharton avatar JakeWharton commented on June 16, 2024

See #34 for my view on the subject :)

from viewpagerindicator.

protyposis avatar protyposis commented on June 16, 2024

Alright. For people in need of a quick fix it might still be helpful ;)

from viewpagerindicator.

JakeWharton avatar JakeWharton commented on June 16, 2024

Agreed. Will merge tonight and probably release as well. I want to get this out before sweeping changes start happening.

from viewpagerindicator.

rfgamaral avatar rfgamaral commented on June 16, 2024

Didn't notice #34, sorry...

I guess this issue can be closed then?

from viewpagerindicator.

JakeWharton avatar JakeWharton commented on June 16, 2024

Closed... but not dead.

from viewpagerindicator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.