Code Monkey home page Code Monkey logo

Comments (4)

JakeWharton avatar JakeWharton commented on June 21, 2024

If it's not @Open or abstract though then what is it? Isn't final all that's left?

from nopen.

bangarharshit avatar bangarharshit commented on June 21, 2024

Fair point. Just avoiding the keyword final. It should be declared @Open or abstract. In the current check Non-final, Non-abstract classes without the @Open annotation will be marked with an error.. How about just treating them as final. All things are final by default and you have to mark @Open to make it subclassable.

from nopen.

JakeWharton avatar JakeWharton commented on June 21, 2024

That still allows their subclassing by downstream libraries. I suppose if the type isn't effectively public then perhaps the check shouldn't apply?

from nopen.

bangarharshit avatar bangarharshit commented on June 21, 2024

Oh. Didn't think of this use case.

from nopen.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.