Electron js support about idb HOT 8 CLOSED

That's been created as part of this pull: #27

It causes node.js to always fail with idb, which is not quite right - Electron, Atom or anything else that provides a browser window could access idb in node, so that check needs to be expanded.

from idb.

let me know how i can help with this

it looks like on line https://github.com/jakearchibald/idb/pull/27/files#diff-0e57e9bd985a92cc0d6572193082ed61R4
and https://github.com/jakearchibald/idb/pull/27/files#diff-0e57e9bd985a92cc0d6572193082ed61R7

we can check if IDBIndex (not window) exists before throwing error

from idb.

Couldn't the check be something like what jQuery implements? For example here are the first few lines of jQuery...

	"use strict";

	if ( typeof module === "object" && typeof module.exports === "object" ) {

		// For CommonJS and CommonJS-like environments where a proper `window`
		// is present, execute the factory and get jQuery.
		// For environments that do not have a `window` with a `document`
		// (such as Node.js), expose a factory as module.exports.
		// This accentuates the need for the creation of a real `window`.
		// e.g. var jQuery = require("jquery")(window);
		// See ticket #14549 for more info.
		module.exports = global.document ?
			factory( global, true ) :
			function( w ) {
				if ( !w.document ) {
					throw new Error( "jQuery requires a window with a document" );
				}
				return factory( w );
			};
	} else {
		factory( global );
	}

// Pass this if window is not defined yet
} )( typeof window !== "undefined" ? window : this, function( window, noGlobal ) {

jQuery still throws errors in the node terminal, but in electron it doesn't.

from idb.

I think we can solve this by having the node version do a bit of feature detecting. Will have a think.

from idb.

@jakearchibald couldn't you check if there was an existing document?

from idb.

https://github.com/jakearchibald/idb/tree/electron-fix should solve the problem. Can someone check?

from idb.

It works in the project that I'm using it in!

from idb.

Merged, and published as 2.0.1! Thanks for the report & help fixing this. I'm delighted, as always, that people find my silly codes useful 😄

from idb.