Comments (2)
And thank you for this one too!
Greg
Date: Sun, 24 Jan 2016 02:45:12 -0800
From: [email protected]
To: [email protected]
Subject: [dhcp] Missing braces in findBindingPool(InetAddress)
results in first pool always being returned (#9)
Although the indentation in findBindingPool(InetAddress) of BaseBindingManager suggests otherwise, the return statement is not part of the if block. This results in the first binding pool of the first list of binding pools to be always returned.
Adding braces to the if statement around the logging and return statements will resolve this.
—
Reply to this email directly or view it on GitHub.
from dhcp.
Resolved by commit cb26a84
from dhcp.
Related Issues (20)
- DHCP Client test tools should allow configuration of request rate
- Add support for JSON and YAML configuration file formats
- Improve Netty inbound/outbound pipeline processing
- DHCPv6 Status Code option handling problems in test client and server
- Consolidate JSON processing to use Jackson API
- DHCPv6 status option missing in IA level of reply message
- Cleanup log messages for undefined or unknown options
- DHCPv6 processing does not check link state when allocating leases
- Update default logging configuration
- Enhance REST API to support server configuration and Swagger/OpenAPI
- Create Docker/OCI images
- Pool reconciliation logic is flawed
- Unable to specify only one IPv4 unicast address HOT 1
- Incorrectly checks for port availability on all NIs for IPv4 broadcast HOT 6
- Options are not deleted on declined or released lease
- DHCPv4 server does not honor client-identifier option
- Minimize DhcpOption class marshalling
- [help] v4VendorSpecificOption in config file doesn't work HOT 2
- Jagornet DHCP Server support add dhcp address pool with API? HOT 1
- Complex option definition types are not parsed into option map, causing NPE on request processing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dhcp.