Build Faild: Module not found: Error: Can't resolve 'canvas' in '/my/local/path/node_modules/jsdom/lib/jsdom' about gatsby-plugin-amp HOT 12 CLOSED

It looks like the canvas package wasn't installed along with jsdom. My first thought is to try reinstalling your dependencies. Can you link to a repo that reproduces the issue?

from gatsby-plugin-amp.

Same problem can easily replicate just by installing and dropping in default configuration

from gatsby-plugin-amp.

It looks like jsdom needs the canvas package. Can either of you try running npm install canvas and try a build again? If that fixes it I’ll add it as a dependency for now until I have time to come up with a better solution.

from gatsby-plugin-amp.

@jafaircl i tried this and unfortunately it did not resolve the issue

from gatsby-plugin-amp.

@jafaircl @jpreecedev

Can you link to a repo that reproduces the issue?

I can't prepare it repository soon but I think the error occur on development env.
gatsby develop

It may be caused the sources are built on web not node.
https://webpack.js.org/concepts/targets/

It seems like jsdom is work on only 'node' .

from gatsby-plugin-amp.

I’ll take a look at it tomorrow and get a better idea of what’s happening and how it can be fixed.

from gatsby-plugin-amp.

Now that I’m looking into it, could you try running npm install canvas-prebuilt? It seems like jsdom is fine with that package and I’m seeing issues in the jsdom repo where that seems to fix similar problems.

from gatsby-plugin-amp.

@jafaircl I can confirm that installing canvas-prebuilt doesn't resolve the issue. Anything I can do to help?

from gatsby-plugin-amp.

Ok after taking a look at it and pushing a new version, 0.1.26 should fix this issue. Please let me know if it doesn’t. Thanks for all your help.

from gatsby-plugin-amp.

@jpreecedev pull requests are always welcome

from gatsby-plugin-amp.

This appears to have been resolved

from gatsby-plugin-amp.

Great. I'll close it for now and if this pops up again I'll reopen it.

from gatsby-plugin-amp.