Code Monkey home page Code Monkey logo

Comments (2)

jacobschaer avatar jacobschaer commented on May 22, 2024

Yeah, makes sense. If you want to PR something that's fine - should be easy enough.

As a workaround, there's no reason you need to let the constructor handle activation. My original intention was for more complicated situations like this you'd set activation_type = None, and then call request_activation() manually with any customization or preconditions already satisfied (for instance, if you need to toggle the physical activation line using some other API).

If you want the library to take care of it automatically (like for auto-reconnect), probably just add a constructor argument called something like

activation_type_vm_specific=None

Store it on the object, and pass it into request_activation wherever we do now (reconnect and constructor).

from python-doipclient.

Mike7Chu avatar Mike7Chu commented on May 22, 2024

Thanks for your reply. I'll try to change activation_type. :)

from python-doipclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.