Code Monkey home page Code Monkey logo

Comments (4)

jab avatar jab commented on August 12, 2024

Please read again and note the difference between self and inv.

from bidict.

jab avatar jab commented on August 12, 2024

Thank you for the code review in any case. If you'd like to share how you found out about bidict and what you're using it for, I'd be interested to hear.

from bidict.

tjomk avatar tjomk commented on August 12, 2024

Ah, it was in plain sight. Not sure why I found this suspicious.

Read about this in Pycoder's Weekly: http://pycoders.com/

from bidict.

jab avatar jab commented on August 12, 2024

Didn't realize you were from Pycoder's Weekly. Thanks for putting bidict in this week!

And I think something about the variable names makes it easy to read something like inv._bwd = self._fwd and think self._bwd = self._fwd by mistake. Maybe renaming inv "inverse" would make it easier to parse. If you spot anything else that looks funny in the code, please don't hesitate to mention.

Thanks again!

from bidict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.