Comments (3)
@iZooGooD can you elaborate a bit more on point 3? Showing Green check mark on input field which has error is not very user friendly. Infactt we should not show the user which field has an error as it would lead to potential security issue. Hence as per best practices, we should simply show a message that states invalid email or password. This has no clear indications and makes it more protected against any attack. Secondly do you prefer for validation to be done using any external library like formik or manual validation instead?
Thanks for the efforts @ahmedkhan1.
My bad, the 3rd point needed to be in registration page to check if a user with that email already exists and for password and confirmation field.
We can use external library, but your current PR handles basic things and these would be enough for now.
from stay-booker-hotel-booking-react-frontend.
I m working on this issue
from stay-booker-hotel-booking-react-frontend.
@iZooGooD can you elaborate a bit more on point 3? Showing Green check mark on input field which has error is not very user friendly. Infactt we should not show the user which field has an error as it would lead to potential security issue. Hence as per best practices, we should simply show a message that states invalid email or password. This has no clear indications and makes it more protected against any attack. Secondly do you prefer for validation to be done using any external library like formik or manual validation instead?
from stay-booker-hotel-booking-react-frontend.
Related Issues (20)
- feat: Enhance Frontend Validation for User Registration
- fix: prevent submission of empty Ratings/Reviews HOT 2
- refactor: Eliminate Console Warning on /login Route HOT 3
- feat: integrate 'Forgot Password' link on login page HOT 3
- feat: add visual indicator for active navigation link HOT 1
- feat: Implement Logout Functionality
- refactor: Minor UI Enhancements for Login and Registration Pages
- feat: Implement Display Limit for Hotel Listings HOT 2
- feat: Enhance Hotels Route with City Query Parameter Support HOT 2
- feat: enhance hotels route with numGuests query parameter support HOT 3
- fix: make login page Buttons and Links responsive HOT 2
- refactor: move dropdown and loader components to UX folder HOT 1
- feat: prevent selection of past dates in hotel booking HOT 6
- feat: display number of nights in final booking summary HOT 2
- feat: enhance responsiveness of rating sections on mobile devices
- feat: format prices with commas for readability on hotel booking details HOT 2
- feat: Automatically fill email field for logged-in users at checkout route HOT 2
- fix: remove console warnings HOT 12
- feat: hide rating selector for non-logged-in folks on Hotel Pages HOT 2
- feat: disable clear filter button when there are no selected filters HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stay-booker-hotel-booking-react-frontend.