Code Monkey home page Code Monkey logo

Comments (3)

iZooGooD avatar iZooGooD commented on July 1, 2024 1

@iZooGooD can you elaborate a bit more on point 3? Showing Green check mark on input field which has error is not very user friendly. Infactt we should not show the user which field has an error as it would lead to potential security issue. Hence as per best practices, we should simply show a message that states invalid email or password. This has no clear indications and makes it more protected against any attack. Secondly do you prefer for validation to be done using any external library like formik or manual validation instead?

Thanks for the efforts @ahmedkhan1.
My bad, the 3rd point needed to be in registration page to check if a user with that email already exists and for password and confirmation field.

We can use external library, but your current PR handles basic things and these would be enough for now.

from stay-booker-hotel-booking-react-frontend.

ahmedkhan1 avatar ahmedkhan1 commented on July 1, 2024

I m working on this issue

from stay-booker-hotel-booking-react-frontend.

ahmedkhan1 avatar ahmedkhan1 commented on July 1, 2024

@iZooGooD can you elaborate a bit more on point 3? Showing Green check mark on input field which has error is not very user friendly. Infactt we should not show the user which field has an error as it would lead to potential security issue. Hence as per best practices, we should simply show a message that states invalid email or password. This has no clear indications and makes it more protected against any attack. Secondly do you prefer for validation to be done using any external library like formik or manual validation instead?

from stay-booker-hotel-booking-react-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.