Separate and Remove Depencies from Implementation Code on Test Code about libphonenumber-ios HOT 4 CLOSED

Thanks your feedback.
I'll cleanup unnecessary imports.

And, why you need framework or static library ?
(You don't want adding source code in your project ?)

from libphonenumber-ios.

Thank you for the quick reply! As for Framework support, it would be a "nice to have" but it's not 100% necessary. And that sounds great about the imports and separating the test code from the actual code. I have changed the title of the issue to reflect the future changes. If you have any questions let me know. :)

from libphonenumber-ios.

see latest commit (a3c85e2)
and feel free to 'create pull request' if you have any good idea.

ps, It works fine... but I'm not satisfy with using pre-define syntax.

thanks :)

from libphonenumber-ios.

Wow that was quick! Yes, I agree with you that using #if macros is not the best solution. But thank you for the fix all the same.

from libphonenumber-ios.