Deprecation of singleton about libphonenumber-ios HOT 8 CLOSED

Yep, You don't worry about that.
Before 0.8.x, "NBPhoneNumberUtil" has Phone number meta data.
But, now (0.8.x) it was moved to NBMetadataHelper. (For better memory/CPU usage)

Anyway, if you want to use "sharedInstance" for convenience, I can remove "deprecated mark".

Ref, https://github.com/iziz/libPhoneNumber-iOS/wiki/Update-Log

from libphonenumber-ios.

Thanks, so we'll switch to allocating the object freshly.

from libphonenumber-ios.

OK, But if you want to use "sharedInstance" for your convenience, just tell me.
I will remove deprecated mark.

from libphonenumber-ios.

No, not a big deal to change it. Actually it saves me from doing the locking on my side. I assume the lib can be called from arbitrary threads?

from libphonenumber-ios.

Yep, I assumed it. but can't guarantee yet :(
and welcome your idea for get rid out of inefficient logic.

from libphonenumber-ios.

Actually I think I would like to have the sharedInstance not deprecated.

I'm working with ReactiveCocoa and libPhoneNumber, and I do not want to refer to self from inside my blocks to make the code more functional. In order to do that I would need a singleton to NBPhoneNumberUtil and it feels silly to duplicate exactly what is already present in [NBPhoneNumberUtil sharedInstance].

I don't really care about the other singleton methods than the basic one, constantly allocating multiple NBPhoneNumberUtil instances on every keypress is just not a good idea IMHO, the singleton should perform better.

So the main problem is thread safety with the underlying libphonenumber?

from libphonenumber-ios.

I see, I will remove deprecation mark.
It is not important issue for singleton or creating instance. and "provide convenience" is more important :)

Anyway, I think it is not main problem "thread safety" in current libphonenumber-ios, but please create the issue if you find some thread problem.

thanks for your feedback.

from libphonenumber-ios.

Ok, thank you!

from libphonenumber-ios.