Could this be bug in the library? In this function <p dir="auto"

Possible Bug in maybeExtractCountryCode... about libphonenumber-ios HOT 2 CLOSED

iziz commented on August 29, 2024

Possible Bug in maybeExtractCountryCode...

from libphonenumber-ios.

Comments (2)

DrJid commented on August 29, 2024

Actually, given that it would also fail for countries like USA (+1) and Russia (+7) Should the MIN_LENGTH_FOR_NSN_ be a smaller value then? Like 1? 🐙

from libphonenumber-ios.

iziz commented on August 29, 2024

+1 and +7 is "countryCode" number.
And, "fullNumber" variable must contain its full phone number
like "+6423456789" or "(1 610) 619 4466"

See, below sample code.

        number = [[NBPhoneNumber alloc] init];
        phoneNumber = @"+6423456789";
        countryCallingCode = @64;
        numberToFill = @"";
        XCTAssertEqualObjects(countryCallingCode, [phoneUtil maybeExtractCountryCode:phoneNumber metadata:metadata
                                                                     nationalNumber:&numberToFill keepRawInput:YES phoneNumber:&number error:nil]);
        XCTAssertEqual(NBECountryCodeSourceFROM_NUMBER_WITH_PLUS_SIGN, [number.countryCodeSource intValue], @"Did not figure out CountryCodeSource correctly");

        number = [[NBPhoneNumber alloc] init];
        phoneNumber = @"+80012345678";
        countryCallingCode = @800;
        numberToFill = @"";
        XCTAssertEqualObjects(countryCallingCode, [phoneUtil maybeExtractCountryCode:phoneNumber metadata:metadata
                                                 nationalNumber:&numberToFill keepRawInput:YES phoneNumber:&number error:nil]);
        XCTAssertEqual(NBECountryCodeSourceFROM_NUMBER_WITH_PLUS_SIGN, [number.countryCodeSource intValue], @"Did not figure out CountryCodeSource correctly");

        number = [[NBPhoneNumber alloc] init];
        phoneNumber = @"2345-6789";
        numberToFill = @"";
        XCTAssertEqual(@0, [phoneUtil maybeExtractCountryCode:phoneNumber metadata:metadata
                                               nationalNumber:&numberToFill keepRawInput:YES phoneNumber:&number error:nil]);
        XCTAssertEqual(NBECountryCodeSourceFROM_DEFAULT_COUNTRY, [number.countryCodeSource intValue], @"Did not figure out CountryCodeSource correctly");

from libphonenumber-ios.

Recommend Projects