Comments (7)
I added this feature. I set the parent of the process (that is created in this action) of the first common ancestor of source and target. If it is undesired I can set it to anything other.
from newt.
This is great. An important potential improvement is the following:
- Create a single process on mouse release (old behavior) when the node where the left click takes place is not a valid substrate or product (e.g. a process or compartment)
from newt.
I made that improvement. Also the edge handles was drawn for convenient process creation for example we start draging in a non EPN node. I prevented it because I suppose it was a bug.
Also I realized that currently we are not considering the tap target upon simple node creation. However, we consider it upon convenient process creation. How about considering it upon simple node creation as well. I mean for example if the tap event is ended in the node A, then the node parent would be A or the parent of A if exists.
from newt.
Yes, let's add nodes to the correct parent in any case
from newt.
I did it in that way. However, while testing I found out a new issue. If you mouse down and up on an EPN in add node mode when the current node type is a PN. A process with convenient edges is created. Actually this is the expected behaviour algorithmically. However, is it the real expected behaiour. I mean shall we have an exception for process creation with convenient edges if the source and target of the process will be the same node?
from newt.
Yes, let's disallow source and target being the same node please
from newt.
I disallow source and target being the same node. I fixed the bug which is preventing process creation with convenient edges when sustainable mode is not active as well.
from newt.
Related Issues (20)
- Spinner not working consistently for large graphs HOT 5
- Solid color scheme not loading
- Tests fail
- To-do for local database integration
- SBML samples in Newt
- SBML help
- Bump Newt version to 4.0.0
- Error on saving imported sbml file HOT 2
- Prepare a legend for SBML HOT 7
- SBML annotations
- SBML import
- Reactome integration
- Removing submaps/compartments is not possible HOT 2
- Validate Map feature does not work in daily build. HOT 1
- Citations HOT 1
- Release a hotfix
- Test Newt 4 and prepare release notes HOT 2
- Merge SBML branch to unstable HOT 1
- state variables glyphs are not loaded properly from SBGN-ML when their state sub-element is prefixed
- conversion of SBGN -> SBML not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newt.