Code Monkey home page Code Monkey logo

Comments (7)

metincansiper avatar metincansiper commented on June 14, 2024

I added this feature. I set the parent of the process (that is created in this action) of the first common ancestor of source and target. If it is undesired I can set it to anything other.

from newt.

ugurdogrusoz avatar ugurdogrusoz commented on June 14, 2024

This is great. An important potential improvement is the following:

  • Create a single process on mouse release (old behavior) when the node where the left click takes place is not a valid substrate or product (e.g. a process or compartment)

from newt.

metincansiper avatar metincansiper commented on June 14, 2024

I made that improvement. Also the edge handles was drawn for convenient process creation for example we start draging in a non EPN node. I prevented it because I suppose it was a bug.

Also I realized that currently we are not considering the tap target upon simple node creation. However, we consider it upon convenient process creation. How about considering it upon simple node creation as well. I mean for example if the tap event is ended in the node A, then the node parent would be A or the parent of A if exists.

from newt.

ugurdogrusoz avatar ugurdogrusoz commented on June 14, 2024

Yes, let's add nodes to the correct parent in any case

from newt.

metincansiper avatar metincansiper commented on June 14, 2024

I did it in that way. However, while testing I found out a new issue. If you mouse down and up on an EPN in add node mode when the current node type is a PN. A process with convenient edges is created. Actually this is the expected behaviour algorithmically. However, is it the real expected behaiour. I mean shall we have an exception for process creation with convenient edges if the source and target of the process will be the same node?

from newt.

ugurdogrusoz avatar ugurdogrusoz commented on June 14, 2024

Yes, let's disallow source and target being the same node please

from newt.

metincansiper avatar metincansiper commented on June 14, 2024

I disallow source and target being the same node. I fixed the bug which is preventing process creation with convenient edges when sustainable mode is not active as well.

from newt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.