Code Monkey home page Code Monkey logo

Comments (8)

simenandre avatar simenandre commented on May 28, 2024

Btw, you can find fastify-frontend-logger here: https://github.com/cobraz/fastify-frontend-logger

from tinga.

ivandotv avatar ivandotv commented on May 28, 2024

What is the use case for this? You don't want to overwhelm the server?
It is an interesting proposition, but I'm concerned about the file size.

from tinga.

simenandre avatar simenandre commented on May 28, 2024

We can probably limit the number of log messages sent to fix that (and the server should also limit that).

The use case is definitely to not overwhelm the server. AFAIK, this is also the default way for services such as Sentry etc.

from tinga.

ivandotv avatar ivandotv commented on May 28, 2024

How about extending the Tinga class?

from tinga.

simenandre avatar simenandre commented on May 28, 2024

Sure, are you thinking it's outside of the scope of the package?

from tinga.

ivandotv avatar ivandotv commented on May 28, 2024

If you end up implementing via extending the class, let me know. If the size increase is small we could add it.
If you batch logs to the server, you may end up with lost data, since the user can close the browser.
But in the case of sendBeacon if the user closes the browser, the data will still be sent, as long as the sendBeacon method has been triggered.

from tinga.

simenandre avatar simenandre commented on May 28, 2024

I can try to open a pull request if you'd like, so we can see what it would entail.

That is a drawback, but we could use the visibilitychange event to fire a last upload.

from tinga.

simenandre avatar simenandre commented on May 28, 2024

Btw, I found this article about the Beacon API.

https://volument.com/blog/sendbeacon-is-broken

Despite the title being sendBeacon is dead, they are currently sampling with visibilitychange which might give some insight to revive it 🤷‍♂️

Anyway, might be off topic, and worth a separate ticket.

from tinga.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.