Code Monkey home page Code Monkey logo

Comments (8)

Horcrux7 avatar Horcrux7 commented on May 22, 2024

We can reproduce the same error also with version 2.18 and 2.17. With version 2.16 it work. It is not a regression in the latest version 2.19. Seems that some things in our server build environment is outdated. The question is what?

from gradle-msbuild-plugin.

ngyukman avatar ngyukman commented on May 22, 2024

Starting from 2.17 we use vswhere from https://github.com/Microsoft/vswhere in order to work with the latest manifold location

Can you try to see if you can get the path from that tool in your Jenkins server?

from gradle-msbuild-plugin.

Horcrux7 avatar Horcrux7 commented on May 22, 2024

I have try to execute vswhere manually on our build system. It returns only the logo.
If I call it with -legacy then I receive:

vswhere -legacy
Visual Studio Locator version 2.3.7+gfb01ddad81
Copyright (C) Microsoft Corporation. All rights reserved.

instanceId: VisualStudio.14.0
installationPath: C:\Program Files (x86)\Microsoft Visual Studio 14.0\
installationVersion: 14.0

from gradle-msbuild-plugin.

ngyukman avatar ngyukman commented on May 22, 2024

https://github.com/Ullink/gradle-msbuild-plugin/blob/master/src/main/groovy/com/ullink/MsbuildResolver.groovy

Perhaps you have version set in your build.gradle manifold section?
That could be a bug indeed

from gradle-msbuild-plugin.

Horcrux7 avatar Horcrux7 commented on May 22, 2024

Yes, we use the version property because without not all of our old projects builds.

from gradle-msbuild-plugin.

Horcrux7 avatar Horcrux7 commented on May 22, 2024

Sorry, I have oversee you question because I have hold the browser open.

Can you try to see if you can get the path from that tool in your Jenkins server?

We does not have vswhere on this docker image. I can't find it. I think it exist first since VS 2015.

If you think that VS 2014 is to old to support it in the current version then this is ok. We want modernize our infrastructure. That I evaluate VS 2017. A better error message with a hint to an old plugin version would be nice.

from gradle-msbuild-plugin.

Horcrux7 avatar Horcrux7 commented on May 22, 2024

After looking in your linked source code:

line 34: def msbuildDir = new File(location, 'MSBuild')

I think it is a good idea to check if the directory exists. If the directory does not exists because it is an error message then MsBuild directory will be search from the registry. This should work with older versions.

from gradle-msbuild-plugin.

ngyukman avatar ngyukman commented on May 22, 2024

I have try to execute vswhere manually on our build system. It returns only the logo.
If I call it with -legacy then I receive:

likely we should add -legacy when invoking vswhere with version <= 14.0

from gradle-msbuild-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.