Code Monkey home page Code Monkey logo

Comments (7)

iTaybb avatar iTaybb commented on August 28, 2024 1

I'll work on it.

from pysmartdl.

iTaybb avatar iTaybb commented on August 28, 2024 1

from pysmartdl.

noam09 avatar noam09 commented on August 28, 2024

Also interested whether this is possible.
Can a download continue if the download is abruptly stopped/killed midway?

from pysmartdl.

cquark7 avatar cquark7 commented on August 28, 2024

This library does not support this feature.

from pysmartdl.

NathanWailes avatar NathanWailes commented on August 28, 2024

Hi @iTaybb , am I correct that this is still not implemented? And am I correct that this feature would/could handle lengthy disconnections? My boss noticed that if he turned off the internet connection and then reconnected it, an active download would start from scratch rather than picking up from where it had left off.

from pysmartdl.

brandonhoughton avatar brandonhoughton commented on August 28, 2024

Looks like the issue with the current implementation is related to a race condition in the recursive threading: https://stackoverflow.com/questions/51879070/python-executor-spawn-tasks-from-done-callback-recursively-submit-tasks

test_hash (__main__.TestSmartDL) ... Exception in thread Thread-9:
Traceback (most recent call last):
  File "C:\Users\brand\AppData\Local\Programs\Python\Python36\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "C:\Users\brand\AppData\Local\Programs\Python\Python36\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "c:\users\brand\source\pysmartdl\pySmartDL\pySmartDL.py", line 645, in post_threadpool_actions
    SmartDLObj.try_next_mirror(HashFailedException(os.path.basename(dest_path), hash, SmartDLObj.hash_code))
  File "c:\users\brand\source\pysmartdl\pySmartDL\pySmartDL.py", line 339, in try_next_mirror
    self.start()
  File "c:\users\brand\source\pysmartdl\pySmartDL\pySmartDL.py", line 292, in start
    self.logger
  File "c:\users\brand\source\pysmartdl\pySmartDL\utils.py", line 284, in submit
    future = super().submit(fn, *args, **kwargs)
  File "C:\Users\brand\AppData\Local\Programs\Python\Python36\lib\concurrent\futures\thread.py", line 117, in submit
    raise RuntimeError('cannot schedule new futures after shutdown')
RuntimeError: cannot schedule new futures after shutdown

from pysmartdl.

mjishnu avatar mjishnu commented on August 28, 2024

will it be possible to add functionality like using a different url only if one fails and continuing downloading from where it left off, this will be usefull for downloading files which have exipre time so even after the link expires we can just use a new link and continue from where we left off. the current mirror function checks before hand if the 2nd url is valid even if the first one is vaild it would be great if it only checked the 2nd url in case the first one fails or returns an error

from pysmartdl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.