Extend ISPyB for cryo-ET and electron diffraction about ispyb-database-modeling HOT 8 OPEN

[minor] In the Tomogram table, I would prefer use tomogramId instead of tomogramID, to follow the existing DB naming convention.

from ispyb-database-modeling.

numberofframes is already in datacollection as number of passes (see https://user-images.githubusercontent.com/4463399/29261785-a6daf4f8-80d1-11e7-9671-9e15fa070d54.png [https://github.com//issues/14])

from ispyb-database-modeling.

Re naming

XaxisCorrection -> xAxisCorrection
Zshift -> zShift

for consistency?

Can we get some background on how this works?

from ispyb-database-modeling.

Thank you both for the feedback! That all sounds good.

Background here:
https://hackmd.io/RCfRD-FaTCagTxeTwVHIaA?view

The text from the above HackMD document was used in the aforementioned iNext Discovery report.

from ispyb-database-modeling.

@stufisher Just checking, are we sure that DC.numberOfPasses and the proposed Movie.numberOfFrames are equivalent? I'm just thinking that there could be multiple Movies in a DC (unless this relationship is meant to be 1 to 1?), each with a different number of frames?

from ispyb-database-modeling.

I think we had agreed
DataCollection -> Movie (many)
numberOfFrames -> no of movies
numberOfPasses -> no of frames per movie

but yes you are right, this assumes that each movie has the same number of frames (i think this is the case, but can they be different?)

who knows what was actually implemented though! maybe have a quick browse of the production db?

from ispyb-database-modeling.

Data in our prod database definitely confirms that there are multiple Movies per DC. (One random DC I looked at had 14600 Movies!)

Apparently, we stopped populating DC.numberOfPasses for cryoEM in 2019.

Anecdotally, looking at the number of MotionCorrectionDrift rows per Movie they do seem to be the same within a DataCollection.

from ispyb-database-modeling.

@KarlLevik, I got feedback from our CryoEM scientist and they are happy with what you suggest. So for me it's ok to go ahead and implement your suggestion.

@stufisher , I had a look on our production DB and this is what we use:
DataCollection -> Movie (many)
DataCollection.numberOfImages: no of frames per movie

We don't store no of movies, it's simply the number of movie entries for a given data collection id.

from ispyb-database-modeling.