Code Monkey home page Code Monkey logo

Comments (5)

RobertBColton avatar RobertBColton commented on September 1, 2024

I would like to know if this issue still exists, platforms, etc.

from lateralgm.

IsmAvatar avatar IsmAvatar commented on September 1, 2024

Since I don't recall the exact details of this, I'll instead provide a test case of acceptable behavior:

  1. Create seven (7) objects.
  2. In the first object (the control), submit other, regular key events, such as letters, spacebar, enter.
  3. In the second, third, and fourth objects, respectively click the Enter, Delete, and Insert key event such that each object has one key event.
  4. Repeat this task for the fifth, sixth, and seventh objects by pressing the keys instead.
  5. In each of these events, place a uniquely visible action, such as "Show a message" with its own text.
  6. Create a starting room and place all the objects in the room.
  7. Save the game.
  8. Load the game in GM6 and GM7. Confirm that the key events retain their intended key.
  9. Run the game in GM6, GM7, and ENIGMA. Confirm that each of the key events behave properly.
    If you have successfully completed all of these steps, ticket passes. If you have difficulty during any of these steps, test case fails - either the solution was incorrect or a separate ticket may be filed as a blocker.

from lateralgm.

RobertBColton avatar RobertBColton commented on September 1, 2024

I forgot about this one, yes I am able to reproduce the issue, I want this fixed and in the 1.8.5 release, will post back with more details.

Edit: When you create an object with the enter key event, and save it as gm81 then load it into GM8.1 it will say

I saved another file with all possible key ranges, and it does appear to be only these 3 buttons.

from lateralgm.

RobertBColton avatar RobertBColton commented on September 1, 2024

Alright I have the fix. I was able to get the enter key to map properly by changing the following line.
https://github.com/IsmAvatar/LateralGM/blob/master/org/lateralgm/resources/sub/Event.java#L344
I changed it to keys.put(13,13); //vk_enter
I also changed the following line to fix the Event Panel.
https://github.com/IsmAvatar/LateralGM/blob/master/org/lateralgm/subframes/EventPanel.java#L165
I changed it to keyboard.add(MainEvent.EV_KEYBOARD,13);

Now I can fix it the way you want and just handle it in all of the writers including the plugin. But I don't see why I can't just create a constant like we did for NO_KEY and ANY_KEY and save ourselves the trouble?

from lateralgm.

RobertBColton avatar RobertBColton commented on September 1, 2024

I have fully fixed this issue in commit 9633a42 by creating a constant as mentioned above and it works in all possible test cases.
Edit: Marking this issue as resolved.

from lateralgm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.