Code Monkey home page Code Monkey logo

Comments (13)

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024 1

Maybe in a future release but now, having the persist and been able to change the user agent, creates more problems that the ones that solves. (History disappearing, white screens...). I close this and, again, I will consider it again one I can get mentions to work with the edge user agent string.

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024 1

@pszalanski , version 0.1.9 persists the session by default (and a couple of other improvements).

Hope helps

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

Hi,

Yeah, I have seen this. I am not sure why is happening but I will investigate further and let you know.

I might end up reverting to persist but the ideal will be to make it configurable. I am not with my laptop at the moment but I will be back soon.

Feel free to pull request a fix if you find it... Maybe passing the actual value (config.partition) when generating the window instead of the config object make work (because object reference Vs value stuff). Give it a try if you wish!

Thanks!

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

I tried with my fix/suggestion and it seems to work!

I have added the change in the branch 0.1.7 with a couple of other changes.

I need to test it tomorrow 1st thing in the morning and then I will create a pre-release.

I will let you know once its available and you can then confirm it also works for you. (using the --partition persist:whatever-you-like)

If you can't wait for it, you could get the branch 0.1.7 but still in testing (it should work but can't warranty until I finish testing tomorrow).

reference/value .... keeps biting me back every now and then.

from teams-for-linux.

pszalanski avatar pszalanski commented on May 19, 2024

Thank you for checking this out so quickly.

So I tested the fix in branch 0.1.7, but it did not fix the persistence issue.

Additionally, switching the user agent does not seem to work anymore. I used it to mimic the edge browser, so video calls are enabled. That does not work anymore.

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

Hi,

I just reverted the changes that where disabling the user agent. As I mention, the branch is still a WIP.

Could you check again? I will change the browser to edge only (with mentions) if I get it all working in a future release.

Apologies if this caused any confusion.

Cheers!

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

I have create a pre-release that is working on my machine and a few colleagues.

https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v0.1.7

Could you test if that fixes this issues?

ps: you might need to remove the ~/.config/teams-for-linux folder, as you did before, if it doesn't seem to finish loading the 1st time.

from teams-for-linux.

pszalanski avatar pszalanski commented on May 19, 2024

Sorry, it does not work. I removed the config folder, uninstalled my current rpm, installed the new rpm, launched using --partition, signed in, launched with the same command line and it is still asking me to sign in 😞

FYI: the repo you forked from, JamieMagee/teams-for-linux, does not have this issue.

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

Hi @pszalanski ,

I think the issue is related to "yargs" module. It seems like the implementation from ivelkov (never released) only work when using the development environment. Once you package it stops working.

This is documented in "yargs" (https://github.com/yargs/yargs/blob/master/docs/api.md#argv).

I have made the change that they suggested and, as it was a pre-release, I have release it again with it.

I have test it now successfully in the packaged version (deb in my case), but I will wait until you confirm this is fix to close it.

ps: apologies, this keeps closing the issue. I had the project setup to do automations and keep doing it. I change it now so hopefully that sorts also that issue out.

Thanks!

from teams-for-linux.

pszalanski avatar pszalanski commented on May 19, 2024

Success!

It works! But only if I launch with --persist. Can you make it the default behavior?

from teams-for-linux.

pszalanski avatar pszalanski commented on May 19, 2024

Yes it did! It works flawlessly now. Thank you!

from teams-for-linux.

rubin55 avatar rubin55 commented on May 19, 2024

@pszalanski I'm on your latest build (0.6.x) which I downloaded today. I am running on Ubuntu 19.04. Every time I have to re-authenticate and am thinking that the authentication/creds are not saved. What can I do to debug? I'm running the .tar.gz version.

from teams-for-linux.

IsmaelMartinez avatar IsmaelMartinez commented on May 19, 2024

Hi @rubin55 ,

Once you start the app, it should print the config folder location. That is normally ~/.config/teams-for-linux

Make sure you got access to that location. Also, I am not sure if it is supported. Have you tried any of the packaged versions? AppImage, snap, deb should work.

Thanks

from teams-for-linux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.