Code Monkey home page Code Monkey logo

Comments (5)

isaacs avatar isaacs commented on July 19, 2024 1

Ah, actually, no, that leads to incorrect types being exported for the commonjs build, which is why tshy enforces that top level types remain unset.

Enable resolvePackageJsonExports, that is the correct way to address this.

from node-glob.

cpojer avatar cpojer commented on July 19, 2024

Can confirm, simply using 10.3.7 and using import { globSync } from 'glob'; causes this error. Downgrading to 10.3.6 resolves the issue.

Repro: https://codesandbox.io/p/sandbox/npm-playground-forked-ch2hmh?file=%2Findex.ts%3A3%2C7

from node-glob.

kiner-tang avatar kiner-tang commented on July 19, 2024

Can confirm, simply using 10.3.7 and using import { globSync } from 'glob'; causes this error. Downgrading to 10.3.6 resolves the issue.

Repro: https://codesandbox.io/p/sandbox/npm-playground-forked-ch2hmh?file=%2Findex.ts%3A3%2C7

Yes, I lock the glob version to 10.3.6 to solve this issue now. Hope to solve this problem soon!

from node-glob.

colinrotherham avatar colinrotherham commented on July 19, 2024

TypeScript won't enable resolvePackageJsonExports by default, but can help for now #556 (comment)

from node-glob.

isaacs avatar isaacs commented on July 19, 2024

I'll add the types field back in, but you really need to start doing "module": "node16" or "module": "nodeNext" in your tsconfigs, or you're almost certainly getting subtly wrong types any time you import a hybrid module, especially if you are building commonjs.

If you have that option enabled, but are still seeing these warnings, make sure that the module emitting the warning is covered by the tsconfig in question (ie, included in files or include, and not excluded by exclude options).

from node-glob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.