Issue with version > 3.1.14 about node-glob HOT 22 CLOSED

Works properly on Unix.

from node-glob.

Seems like it works properly on Windows as well:

C:\globtest\node-glob\test>cat g.js
var glob = require('glob');
var path = require('path');

glob(__dirname + '/**/*', function (err, matches) {
 console.log(matches); // matches is ok
});

C:\globtest\node-glob\test>node g.js
[ 'C:\\globtest\\node-glob\\test/00-setup.js',
  'C:\\globtest\\node-glob\\test/bash-comparison.js',
  'C:\\globtest\\node-glob\\test/bash-results.json',
  'C:\\globtest\\node-glob\\test/cwd-test.js',
  'C:\\globtest\\node-glob\\test/g.js',
  'C:\\globtest\\node-glob\\test/mark.js',
  'C:\\globtest\\node-glob\\test/pause-resume.js',
  'C:\\globtest\\node-glob\\test/root-nomount.js',
  'C:\\globtest\\node-glob\\test/root.js',
  'C:\\globtest\\node-glob\\test/zz-cleanup.js' ]

from node-glob.

This is using glob 3.1.17, btw.

from node-glob.

@isaacs thats really strange because the same gives me an empty array.

I've tested this in two windows 7 machines with the same result. I noticed that you did cat in the command line, which is not available. Are you running that in cygwin or similar? I'm running the same tests in a normal cmd.exe.

I'm using [email protected]. If I install [email protected] everything works fine.

from node-glob.

Version [email protected] is also fine, but [email protected] has the issue. Something after it is the culprit.

from node-glob.

I installed the msysutil suite with git, but it's normal cmd otherwise. I just don't know most of the windows equivalents.

What is the actual output?

from node-glob.

That is, what is the output if glob(__dirname + '/**/*') vs the output of glob('**/*')?

from node-glob.

Also, what is node -v?

from node-glob.

v.0.8.16, going to add some screenshots.

from node-glob.

Type Alt-Space, E, K, then select with your mouse, then press Enter. This copies the output to your clipboard, and you can paste it into a code block with ```

from node-glob.

The test folder has one file called dsadsa.txt.

Running:

var glob = require('glob');

glob('test/**/*', function (err, matches) {
    console.log(matches);
});

Running:

var glob = require('glob');

glob(__dirname + '/test/**/*', function (err, matches) {
    console.log(matches);
});

from node-glob.

Put a / in front of 'test'. Echo out the actual path that you're globbing, you'll see the problem right away, I'm sure. (__dirname doesn't end in a slash.)

from node-glob.

-glob(__dirname + 'test/**/*', function (err, matches) {
+glob(__dirname + '/test/**/*', function (err, matches) {

from node-glob.

@isaacs it was a typo typing the comment, the actual file contains the /

from node-glob.

var glob = require('glob');

var pattern = __dirname + '/test/**/*';
console.log('pattern is:', pattern);

glob(pattern, function (err, matches) {
    console.log(matches);
});

from node-glob.

Also tried path.normalize before passing the pattern, same issue.
Maybe the issue is related to the fact that the pattern contains backslahes?

from node-glob.

Seems not.

var glob = require('glob');

var pattern = (__dirname + '/test/**/*').replace(/\\/g, '/');
console.log('pattern is:', pattern);

glob(pattern, function (err, matches) {
    console.log(matches);
});

..didn't fixed the issue.

any thoughts?

from node-glob.

Aha! Ok, reproducing now:

var glob = require('glob');

var p1 = 'test/**/*';
glob(p1, function (err, matches) {
    console.log(p1, matches);
});

var p2 = __dirname + '/' + p1;
glob(p2, function (er, matches) {
    console.log(p2, matches);
});

Output:

c:\globtest\Helena>node test.js
c:\globtest\Helena/test/**/* []
test/**/* [ 'test/asdasd.txt',
  'test/dir',
  'test/dir/a.txt',
  'test/dir/b.txt',
  'test/dsadsa.txt' ]

Folder structure:

test/
test/asdasd.txt
test/dir/
test/dir/a.txt
test/dir/b.txt
test/dsadsa.txt

from node-glob.

Now I'm confused about why it's working sometimes, but not in this specific case... Very strange.

from node-glob.

I'm glad that you reproduced it. Looking forward for a new release that fixes this. Going to truncate glob on 3.1.15 for now.

from node-glob.

@isaacs It now expands correctly but using mark: true does not mark directories with / or \ at the end.

from node-glob.

@satazor Separate issue. Please file a separate bug with a reproduction case.

from node-glob.