Code Monkey home page Code Monkey logo

Comments (4)

isaacs avatar isaacs commented on July 19, 2024 1

Fixed on master, published as glob 3.1

from node-glob.

TooTallNate avatar TooTallNate commented on July 19, 2024

@isaacs This was an unexpected change for me as well. What's the deal?

from node-glob.

TooTallNate avatar TooTallNate commented on July 19, 2024

We're having to do something ghetto like this after the glob result to "normalize":

var cwd = process.cwd();
function fix (f) {
  if (f[0] === '/') {
    // Good
    return f;
  } else {
    // `glob` stripped CWD...
    return path.join(cwd, f);
  }
}

result = result.map(fix);

from node-glob.

isaacs avatar isaacs commented on July 19, 2024

Yeah, it's a bug. Haven't had a chance to fix it yet.

The solution is to detect whether each pattern in the set is absolute or not, and only strip the cwd from each result if it was not an absolute pattern.

Also, weird though it may be, there were previous cases where {/foo,/foo} would return the same thing more than once, so each match needs to be tied to a given glob in the set. That's the ultimate solution, though @TooTallNate's workaround is ok for the short-term.

from node-glob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.