Replace networkidle with waitFor about strava-kudos HOT 10 CLOSED

Hey, thanks for bringing this up. A few questions:

• Impact: Wondering how much this is affecting the current setup? (I haven't noticed any missed kudos lately) and where would this apply to (only login?)?
• Potential "fix": What should the state for wait_for be? Maybe visible?

from strava-kudos.

I noticed it on the dashboard page. The page was loaded and networkidle was triggered but there where no web-feed-entry available. So those get lazy loaded by strava.

wait_for waits until a DOM element is available so my guess is to wait until the first web-feed-entry is available and then add a delay for about further 500ms just to be sure?

In my private version I also save the browser local storage after the login happend and the dashboard is loaded to prevent a relogin for the next execution. I did it because I run the script every 5 minutes on my server and to quick logins seems to trigger a rate limit by strava and then they add a captcha check on the login page.

This is the documentation for the storage stuff:
https://playwright.dev/python/docs/auth#reusing-signed-in-state

You don't need to persist the session storage the first example is enough. Should be pretty easy to persist the json for further github actions runs

from strava-kudos.

Nice find on the session storage stuff. We could implement that if we choose to.

As for the lazy loading from strava, any idea what triggers the loading? A scroll maybe? or any random action? There might be a chance that we switch to wait_for and still no DOM elements are available. I also wonder if we can measure that somehow?

from strava-kudos.

The ajax call just needs some time, I currently still use networkidle but with another delay of 2sec. This also works fine but could break in the future.

from strava-kudos.

I see. Have you tried using waitFor in your fork then?

from strava-kudos.

Not yet, didn't have time for it and I am also busy the next 1-2 weeks. But the docs sound promising for this case

from strava-kudos.

All good, I'm in a similar situation in the next few weeks. Once some testing has been done and if it seems to be more reliable, then we can look at a PR together. Thanks again for bringing this up.

from strava-kudos.

I messed around with waitFor, couldn't get it to work... retries still timing out. Will keep messing with it.

from strava-kudos.

Closing this now. Feel free to reopen later.

from strava-kudos.

Note that #11 is related to the lazy loading discussion. Instead of waitFor, scrolling was added. Please update your forks if you are seeing failures related to that.

from strava-kudos.