Options from router, and routes should be passed along to controller instances about iron-router HOT 6 CLOSED

loadingTemplate and notFoundTemplate wasn't working. After 2 hours of debugging i found out that when i define initialize method i have overriden RouteController's initialize method and router couldn't pass options to controller. Now i'm using onBeforeRun instead of initialize. Everything works fine.

I think when we define initialize method while extending a class instead of overriding parent's initialize both parent's and child's initialize methods should run just like Java.

I think this might help you clean up more code and could automatically solve this issue (#35).

from iron-router.

Agreed on the initialize method. That was a quick last minute change to give server/client routers a chance to deal differently with initialization, but that logic should be in an overridden constructor. The current behavior is counter intuitive, and people probably won't remember to call the super method.

from iron-router.

I'm sure you've got some design in your mind before starting to implement Posture

I want to share 3 ideas that might improve the design:

1-) using something like http://underscorejs.org/#after (though it might open parent's scope to child)
2-) executing super before extending fields
3-) some hook like onAfterInit to call after super

I can always take some of the work if you don't have time.

from iron-router.

Hey @yasinuslu, Are you talking about the private Posture package? Or the inheritance mechanism with RouteController?

from iron-router.

Sorry @cmather i didn't have time lately. I thought Posture was the package providing OOP features for RouteController when i wrote my comment :) Yes i'm talking about inheritance mechanism.

from iron-router.

All of this should be cleaned up quite a bit in dev. I'm just using the regular constructor now and calling super methods using the Class.super. You can look at lib/client/route_controller as an example.

from iron-router.