Attempt to compare number with string in Mode.lua:296 about nvim-libmodal HOT 5 CLOSED

now i'm no lua expert,
but what i did here is

if tonumber(user_input) ~= nil and 0 <= tonumber(user_input) and tonumber(user_input) <= 9 or not tonumber(user_input) == nil then
         local oldCount = self.count:get()
         local newCount = tonumber(oldCount .. string.char(user_input))
         self.count:set(newCount)
 end

from nvim-libmodal.

Can you share the mode which produced this error?

from nvim-libmodal.

This looks like a regression. From what I can tell the problem occurs because of this.

getchar will not always return a number (for example, pressing the left arrow key will return a string with the same value as "<Left>"), so when you press any key that produces a string, it will be compared against a number and will error out.

I will try to submit a fix later today

from nvim-libmodal.

Seems like it really is that easy: #38
I tested it with my own plugin and it works perfectly again

from nvim-libmodal.

This can be closed now I believe. Can you still produce the error on master @IkaSek?

from nvim-libmodal.