Comments (2)
Hi, thanks for pointing this one out!
We did indeed get the errors that we have reported in the paper. This is what we see in our machines, using Matlab version 2017a or older:
However, we looked more into this matter and came across the following problems:
-
All operations were performed in single precision (as both the network output and the depth ground truth came in single precision). However, as we sum and divide over all pixels, it turns out that their number is way too large to be handled by single precision and this leads to precision errors. We would like to report that correct evaluation requires double precision and thus we will update all reported errors (rel: 0.140, rmse: 0.597). This does not affect the delta measures.
-
This understanding came when we tested the predictions with Matlab 2017b. With this version, it looks like all operations are internally performed with double precision, even when the matrices are provided as single. Therefore, using our code in 2017b one can get accurate results.
-
In general, we observed that different versions of Matlab might cause different results, especially on different machines. It depends on different factors, such as 32-bit/64-bit, the C compiler used, etc. Similar issues have been reported: e.g. https://uk.mathworks.com/matlabcentral/answers/438-why-are-computational-results-in-matlab-sometimes-different-on-different-machines-and-how-can-i-prev
-
There might also be small differences in the output between python/matlab scripts, because of the above.
-
While investigating this, we also realized that there are perhaps small differences in how different methods evaluate their predicted depth maps. We believe that most methods use a certain center crop (as suggested by the NYU Depth dataset) in which the depth values are valid. This generally reduces errors (rel: 0.136, rmse: 0.584 in double precision). For completeness and fairness of comparisons, we will now report errors using this evaluation protocol as well.
-
We will of course update accordingly the error metrics calculation script as soon as possible.
from fcrn-depthprediction.
So to make sure I understood this correctly:
- The results in the paper are inaccurate and you're going to publish an update to the paper to include the correct results.
Or,
- The results in the paper are correct, and the evaluation code used by the op is wrong.
Can someone confirm?
from fcrn-depthprediction.
Related Issues (20)
- NYU Depth results link not working
- make3d
- Output upsampling to original resolution HOT 1
- Question about the evaluation method
- Could not find Implementation of its Application for SLAM??
- units for the depth map HOT 1
- Model transfer
- Can this code be used to obtain depth from kitti images? HOT 1
- training code for tensorflow
- Tensorflow model for Make3D? HOT 1
- Output of predict.py HOT 1
- Not getting good result after training HOT 2
- Got a core dumped issue
- How to make ground truth
- How should the input size be filled
- what can the depth esitimation picture do? HOT 4
- Matlab; invalid input syntax HOT 3
- Running predict.py on multiple images
- Why loss the link of .ckpt file ? HOT 1
- CKPT url not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fcrn-depthprediction.