bidir_search_fwd is broken about gramtools HOT 6 CLOSED

As a result of this, I've commented out any _fwd() tests in the unit tests for now
at commit bc842fa

from gramtools.

Yes, I'm not surprised. I did all the debugging on bidir_search_bwd and might have forgotten to mirror all the bugfixes or mirrored them blindly without considering the differences in forward search. For example, we need to keep in mind that in a forward search we are adding sites in reverse order compared to backward search. So I think back and front should be swapped in all aassertions

from gramtools.

Yes I put the assertions swapped - and that works - ie it correctly finds the sites in the other order. So it's probably a small thing about site adding. One thing that is not clear to me is hoe lef/tright and left_rev/right_rev are supposed to work in the _fwd function.

from gramtools.

[left,right) is the interval in the suffix array of the reverse string (the one the forward search is done on) and [left_rev,right_rev) is the corresponding interval in the suffix array of the normal string. hmm maybe notation is confusing

from gramtools.

I just wasn't sure what left_new and left_rev new meant. I think I just need to sit with a clear head

from gramtools.

Issue no longer needed.

from gramtools.