Can IMidiQueue be replaced with IPlugQueue? about iplug2 HOT 8 CLOSED

I love tidying. I'll give it a try.

from iplug2.

@madronalabs - have you taken a look at this at all?

I've just glanced at it but what I see is:

• IMIDIQueue doesn't appear to have any thread safety
• IPlugQueue is a fixed size queue, whereas IMIDIQueue can grow and shrink freely.
• IMIDIQueue uses a system of moving memory around that seems inefficient and unnecessary - it looks like it never loops and instead moves all the data around.

I pretty sure it can be done fairly easily with mostly gains, if we can live with the fixed size queue.

from iplug2.

Quick attempt on VST3 shows it isn't too hard, but we need a way to resize the queue (there isn't one currently and the default move constructor doesn't seem happy so doing std::swap doesn't work either)...

The resize shouldn't need to be threadsafe

from iplug2.

All seems reasonable. I added the Resize method, see my PR

from iplug2.

Thanks - if @olilarkin can tell me what size he things the queue should be in AAX I can make a branch that gets replaces IMIDIQueue with IPlugQueueready for testing.

from iplug2.

@madronalabs - probably Resize() should also clear, as it might resize downwards and that could invalidate the counters. Pulled it in, but it seems like that could be unsafe right now.

from iplug2.

I have what I think is a rough version working here:

https://github.com/iPlug2/iPlug2/tree/IMIDIQueue-removal

this is ready for testing, but I have a couple of things to go through with Oli, plus a need to fix the counter issue on Resize() mentioned above.

from iplug2.

I am going to close this and keep IMidiQueue for now. I have too many things that depend on it. Will keep your branch elsewhere and may revisit it at some point

from iplug2.