Code Monkey home page Code Monkey logo

Comments (1)

AlexHarker avatar AlexHarker commented on May 26, 2024 1

Thanks for the report.

This looks like it needs wider checking than the PR as it also affects getMouseRight and we need to ensure parity with windows. There might be some discussion to be had about what should happen for mouseups for instance (as this is a possible mechanism for a dev to differentiate left/right mouse ups. It would also be a little bit of detective work to figure out what was happening before I made the restructure that introduced these methods.

The PR looks like a sensible proposition as a starting point, but we need to ensure consistency. (As a more minor matter, PRs that match formatting are easier to merge directly and in this case the opening curly bracket has been moved on the method)

This issue relates to #635 and they should be resolved together

from iplug2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.