Suggestion: Change CID type so it can be passed around directly and not by pointer about go-cid HOT 2 CLOSED

From my experience today trying to replace Multiaddr with a bare type, this will be fun as we probably rely on the fact that Cids are nullable all over the place (although I agree we should probably do this anyways).

We could also just go straight to an interface.

Note: For my usecase, it's actually fine to continue passing it around as a pointer as long as I can cheaply extract some key to use in a map (either by dereferencing it or pulling out some field).

from go-cid.

this will be fun

If we decide to go though with this I can likely do most of the work and probably in a day or two. I will need someone to help me with using gx-workspace, though, for handling the dependency updates.

probably rely on the fact that Cids are nullable all over the place

Maybe, in the cases where this is true we can use a pointer or we can have a special "empty" CID value. We won't know how bad this is until we try.

We could also just go straight to an interface.

I would be against this, it adds an extra level of indirection that I was trying to get ride of. I also think it will be overkill in this case.

from go-cid.