Code Monkey home page Code Monkey logo

Comments (9)

patrickdet avatar patrickdet commented on June 10, 2024 1

I have dug into this some more and it appears to me that the problem happens due to the switch to Async Iterables https://gist.github.com/alanshaw/04b2ddc35a6fff25c040c011ac6acf26#file-migration-md

I will have a look whether I can send a PR with the fix

from js-did-ipid.

HLK65 avatar HLK65 commented on June 10, 2024

Full file for a better understanding https://pastebin.com/tjyDTCBf

from js-did-ipid.

autonome avatar autonome commented on June 10, 2024

@satazor any ideas? Also filed on https://stackoverflow.com/questions/62430111/issue-adding-resolving-did-docs-with-js-did-ipid

from js-did-ipid.

patrickdet avatar patrickdet commented on June 10, 2024

I am running into the exact same issue that @HLK65 is describing. The part of await _classPrivateFieldGet(this, _ipfs).name.resolve(identifier); returns undefined in all cases I have tried.

from js-did-ipid.

patrickdet avatar patrickdet commented on June 10, 2024

So from the ipfs-js docs (https://github.com/ipfs/js-ipfs/blob/master/docs/core-api/NAME.md#ipfsnameresolvevalue-options) it looks like the publish identifier needs to look like /ipns/....

The publish function of the js-did-ipid library calls ipfs.name.publish with a path that starts with /ipfs/...

js-did-ipid/src/index.js

Lines 68 to 70 in a32bec2

const path = `/ipfs/${cid.toBaseEncodedString()}`;
await this.#ipfs.name.publish(path, {

I might be wrong.

from js-did-ipid.

autonome avatar autonome commented on June 10, 2024

Ahhhh. Thanks for investigating @patrickdet!

@satazor can you review or suggest a reviewer?

from js-did-ipid.

HLK65 avatar HLK65 commented on June 10, 2024

Thank you for digging in and fixing @patrickdet !
I'll hopefully find the time to test it tomorrow.

from js-did-ipid.

HLK65 avatar HLK65 commented on June 10, 2024

It's working, thank you so much!

from js-did-ipid.

satazor avatar satazor commented on June 10, 2024

Reviewed!

from js-did-ipid.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.