Code Monkey home page Code Monkey logo

Comments (3)

rmunn avatar rmunn commented on August 20, 2024

Note that #6 uses text.md as the Markdown syntax. That may or may not be the best choice in the long run, so if something else is better for the sake of VS Code users, that can be adjusted.

from ionide-fsgrammar.

Krzysztof-Cieslak avatar Krzysztof-Cieslak commented on August 20, 2024

I'm not sure if I want to go with it. There is lot of assumptions done for this PR to make it work

  1. It assumes Atom and grammar it's reused in both Atom and VSCode.
  2. It assumes specific grammar for Atom (when other can be also used)
  3. It assumes using markdown for comments (and you can't turn on-off grammar parts dynamically)

I will leave it open, and think a bit more about it. But for now I'm not sure if it's good idea.

from ionide-fsgrammar.

rmunn avatar rmunn commented on August 20, 2024

Yes, all those are issues that I thought of, and may be good reasons to say "no" to this feature. I have had a few ideas for fixing some of these, but haven't tested them yet:

  1. What happens if you include more than one syntax grammar? I.e., if you include both the text.md and the source.gfm syntaxes? If the two syntax grammars would end up "fighting" over Markdown syntax, that would be less than ideal -- but if they wouldn't interfere with each other, then you could do:
"include": "atom-markdown-syntax-name",
"include": "vscode-markdown-syntax-name"

As for the "assumes using markdown for comments" objection, that was something I was willing to assume. The F# way seems to be to nudge people towards the "right" way to do things in a "pit of success" style, and Markdown is much better than XML for comment documentation. But if there is a significant amount of code out there using XML in /// comments, and people actively dislike finding it Markdown-highlighted, that would be a good reason to reject this idea.

I'll try installing both Atom's language-markdown and language-gfm plugins, to see if they end up "fighting" over Markdown-in-comments, and report my results.

from ionide-fsgrammar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.