Comments (3)
Note that #6 uses text.md
as the Markdown syntax. That may or may not be the best choice in the long run, so if something else is better for the sake of VS Code users, that can be adjusted.
from ionide-fsgrammar.
I'm not sure if I want to go with it. There is lot of assumptions done for this PR to make it work
- It assumes Atom and grammar it's reused in both Atom and VSCode.
- It assumes specific grammar for Atom (when other can be also used)
- It assumes using markdown for comments (and you can't turn on-off grammar parts dynamically)
I will leave it open, and think a bit more about it. But for now I'm not sure if it's good idea.
from ionide-fsgrammar.
Yes, all those are issues that I thought of, and may be good reasons to say "no" to this feature. I have had a few ideas for fixing some of these, but haven't tested them yet:
- What happens if you
include
more than one syntax grammar? I.e., if youinclude
both thetext.md
and thesource.gfm
syntaxes? If the two syntax grammars would end up "fighting" over Markdown syntax, that would be less than ideal -- but if they wouldn't interfere with each other, then you could do:
"include": "atom-markdown-syntax-name",
"include": "vscode-markdown-syntax-name"
As for the "assumes using markdown for comments" objection, that was something I was willing to assume. The F# way seems to be to nudge people towards the "right" way to do things in a "pit of success" style, and Markdown is much better than XML for comment documentation. But if there is a significant amount of code out there using XML in ///
comments, and people actively dislike finding it Markdown-highlighted, that would be a good reason to reject this idea.
I'll try installing both Atom's language-markdown
and language-gfm
plugins, to see if they end up "fighting" over Markdown-in-comments, and report my results.
from ionide-fsgrammar.
Related Issues (20)
- Ability to specify highlighting color for symbols HOT 15
- There are syntax highlighting problems with value names that contain keywords.
- Multiple `` in one line are not highlighted correctly
- // inside a block comment gets line comment scope
- Similar lines highlighted differently HOT 3
- let f = (*) 2 is highlighted as a comment HOT 3
- Ionide hangs when trying to load `.fsproj`s or `.sln` HOT 1
- Multiline comments captures too greedily HOT 4
- Space after a closing *) literate comment breaks ionide highlighting
- Some bindings are missing? HOT 1
- Unexpected grammar tokenization HOT 3
- Conflict between custom operator and line comment
- Syntax highlighting breaks when returning a binding that begins with "use" HOT 1
- Bug: Slice parameters are tokenized as part of the function itself HOT 2
- Having `*` in the member definition makes everything after coloured incorrectly. HOT 1
- Syntax highlighting missing for `let struct` HOT 2
- Missing colorisation or broken colorisation on some syntax for `abstract` definition with a generic
- Rogue `"begin/endCaptures"` HOT 2
- Infix multiplication operator is treated as block comment terminator HOT 3
- Infix multiplication operator screws up parentheses coloring and is highlighted in red HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ionide-fsgrammar.