Angular 10: Class is using Angular features but is not decorated about stencil-ds-output-targets HOT 8 CLOSED

For me it occurs on an abstract class.

Same story...

Angular team, please let us write normal abstract/base classes. This limitation looks ridiculous. It forces me to decorate my abstract class just because it implements OnDestroy interface.

And even more, compiler emits this error only in normal mode. When I run the prod build, everything's fine.

@Injectable() // 👈 I have to add this for no real reason to satisfy the compiler. why?!
export abstract class LocalStore<TState> extends StoreBase<TState> implements OnDestroy {
  ngOnDestroy(): void {
    this.complete();
  }
}

from stencil-ds-output-targets.

For me it occurs on an abstract class.

from stencil-ds-output-targets.

I ran into this error, I am using 0.0.2 of the output, but my output project has been upgraded to use 10.x of angular..

from stencil-ds-output-targets.

For me it occurs on an abstract class.

Same here.

from stencil-ds-output-targets.

After upgrading from:

{
  "@stencil/angular-output-target": "0.0.2",
  "@stencil/core": "1.15.0",
  "@stencil/sass": "1.3.2"
}

to

{
    "@stencil/angular-output-target": "0.0.6",
    "@stencil/core": "2.6.0",
    "@stencil/sass": "1.4.1"
}

It just works without any workaround 🎉

from stencil-ds-output-targets.

After upgrading from:

{
  "@stencil/angular-output-target": "0.0.2",
  "@stencil/core": "1.15.0",
  "@stencil/sass": "1.3.2"
}

to

{
    "@stencil/angular-output-target": "0.0.6",
    "@stencil/core": "2.6.0",
    "@stencil/sass": "1.4.1"
}

It just works without any workaround 🎉

I'm using @stencil/angular-output-target v0.2.0, and I am still getting this issue. I get a warning that value-accessor.ts has no selector and "Cannot determine the module for class ValueAccessor in ****! Add ValueAccessor to the NgModule to fix it." Again, this appears to still be an issue.

Is there a goal or anything to eventually update the examples for the stencil-ds-output-targets repo? The examples appear relatively outdated, and the version being used is 0.0.5 for Angular, but it appears that you've recently released 0.2.0. Are there any other breaking changes? Should I downgrade back to 0.0.5 for this to work properly?

My @stencil/core version is 2.8.1 at the moment, btw.

from stencil-ds-output-targets.

I downgraded to 0.0.5, and it's working. I'm sure I must be missing something or doing something wrong, but I'll keep it like this for now until further updates occur.

from stencil-ds-output-targets.

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the output targets, please create a new issue and ensure the template is fully filled out.

from stencil-ds-output-targets.