Comments (2)
ion-page does receive a class automatically. So in the above example it'd get <ion-page class="page1-page">
. However, it's a hidden feature, and might be confusing to devs as to where it's coming from. It also directly ties the JS to the CSS.
We should investigate ng2 stylesheets further now that they've solidified. The part that really needs to be reviewed though is how well they work in practice, on a low end mobile device. Basically it inserts new stylesheets to the head, which will cause an entire document reflow. Additionally, we'd have to update the build process so it knows how to pull in their files and ionic's files.
from ionic2-app-base.
This is fixed. @adamdbradley do you want to create a new issue for that?
from ionic2-app-base.
Related Issues (20)
- question: Order of polyfills.js HOT 6
- ionic-native is not supposed to be updated? HOT 2
- Network native plugin HOT 1
- Use @angular/router: UNMET PEER DEPENDENCY and transpile failed HOT 2
- EPEERINVALID on "ionic start" HOT 1
- Dependency problem HOT 3
- Cannot find module "ionic-native" HOT 4
- ionic 2 page redirection automatically HOT 1
- unmet dependencies upon upgrading to ionic 3 HOT 1
- Things in resources folder are not used HOT 1
- deprecated main.dev.ts
- Native cor dep will cause unmet peers with the versions from ionic native plugins HOT 2
- Ionic icons are not getting cached in PWA HOT 2
- question: why was declarations.d.ts removed? HOT 1
- @ionic/app-scripts 2.0.0 live update not work HOT 1
- Add vendor.js to service-worker? HOT 1
- Outdated native package versions HOT 1
- "Homepage" name may be repeated
- Evaluate this repo for closure HOT 1
- Unexpected token ILLEGAL in main.js
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ionic2-app-base.