Comments (3)
The issue is having the helpers file in general for a template app. The patterns we use are going to dictate to the community how they should lay out their app, and we should avoid having global helpers unless we are absolutely certain all apps will need it. If a certain component needs that, just include it in the component instead of making a global helper.
from ionic-pwa-toolkit.
@mlynch Just to explain why this function is here, we are currently using this function here https://github.com/ionic-team/ionic-pwa-toolkit/blob/master/src/components/app-profile/app-profile.tsx#L21 to convert the key to the format that web push notifications needs. I got this function from the google web fundamentals docs on web push notifcations https://developers.google.com/web/fundamentals/push-notifications/subscribing-a-user. Is there a better way to do this that you're aware of?
from ionic-pwa-toolkit.
Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of the Ionic PWA Toolkit, please create a new issue and ensure the template is fully filled out.
Thank you for using Ionic!
from ionic-pwa-toolkit.
Related Issues (20)
- Failing unit tests in master
- Missing types for Ionic components HOT 1
- Main PWA site is charged to left
- Add variables
- npm start is not working HOT 1
- Routing is slow at first when hosted on the web (Firebase) HOT 1
- service worker - not being generated HOT 1
- CSS Utils don't work inside the project
- Needs upgrade to Ionic v6
- ionic-pwa starter option does not produce a service worker file.
- The iphone x emulator menu does not work.
- Profile page 404 when deployed, works on localhost HOT 1
- Demo: AppHome loaded twice HOT 1
- Can't import ES2015 modules
- what is the difference between ionic-pwa-toolkit and ionic 4 + service worker enabled? HOT 5
- npm start.sw missing script HOT 3
- Remove transparency for iOS App Icon
- Routing library inconsistently described
- Stencil 0.7.0 with ionic/core 4.0.0 don't work HOT 1
- Host styling not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ionic-pwa-toolkit.