Code Monkey home page Code Monkey logo

Comments (3)

mlynch avatar mlynch commented on May 28, 2024 1

The issue is having the helpers file in general for a template app. The patterns we use are going to dictate to the community how they should lay out their app, and we should avoid having global helpers unless we are absolutely certain all apps will need it. If a certain component needs that, just include it in the component instead of making a global helper.

from ionic-pwa-toolkit.

jgw96 avatar jgw96 commented on May 28, 2024

@mlynch Just to explain why this function is here, we are currently using this function here https://github.com/ionic-team/ionic-pwa-toolkit/blob/master/src/components/app-profile/app-profile.tsx#L21 to convert the key to the format that web push notifications needs. I got this function from the google web fundamentals docs on web push notifcations https://developers.google.com/web/fundamentals/push-notifications/subscribing-a-user. Is there a better way to do this that you're aware of?

from ionic-pwa-toolkit.

ionitron-bot avatar ionitron-bot commented on May 28, 2024

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of the Ionic PWA Toolkit, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

from ionic-pwa-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.